Update ingress api version, extension/v1beta1 will not be supported i… #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n new k8s version, this change keep backward compatibility for lower kubernetes version
|
Could anybody in the team please review this PR? Thanks. |
lhotari
requested review from
codelipenghui,
michaeljmarshall,
eolivelli and
sijie
michaeljmarshall
requested changes
Jan 3, 2022
There was a problem hiding this comment.
Great work @wangshu3000! I think it might make sense to modify the conditionals in the PR. Let me know what you think. Otherwise, this looks good to me.
|
@lhotari - do you know why the CI checks wouldn't have run for this PR? I haven't seen that happen before. |
…ities.KubeVersion.Version
michaeljmarshall
approved these changes
Jan 4, 2022
There was a problem hiding this comment.
LGTM. @wangshu3000 - looks like the tests ran against this latest PR, so that's good too.
pgier
pushed a commit
to pgier/pulsar-helm-chart
that referenced
this pull request
Apr 22, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n new k8s version, this change keep backward compatibility for lower kubernetes version
Fixes #157
Motivation
The ingress api extensions/v1beta1 version will not be supported in k8s version 1.22+, need to update to new networking.k8s.io/v1.
This PR also keep support for old k8s version, to provide enough compatibility.
Modifications
Updated the api version for below 4 components:
Verifying this change