Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][pip] PIP-320: OpenTelemetry Scaffolding #21635

Merged
merged 10 commits into from
Dec 13, 2023

Conversation

asafm
Copy link
Contributor

@asafm asafm commented Nov 28, 2023

Motivation

Adding PIP-320, which a sub-PIP of PIP-264 (Implementation tracked at #21121).
This PIP is about adding the infrastructure to use OpenTelemetry in Pulsar broker, proxy and function worker.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Copy link

@asafm Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Nov 28, 2023
pip/pip-320.md Outdated Show resolved Hide resolved
@visortelle
Copy link
Member

I left some comments. Asked questions I was interested in during the reading.
Don't consider it a review. I’m not deep enough into the metrics/OTel topic to leave comments that may be considered as a review.

Copy link
Contributor

@Apurva007 Apurva007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small clarifications needed. Overall looks good.

pip/pip-320.md Outdated Show resolved Hide resolved
pip/pip-320.md Show resolved Hide resolved
pip/pip-320.md Show resolved Hide resolved
pip/pip-320.md Outdated Show resolved Hide resolved
@BewareMyPower
Copy link
Contributor

LGTM

Copy link
Contributor

@Apurva007 Apurva007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asafm
Copy link
Contributor Author

asafm commented Dec 13, 2023

@lhotari The vote has been concluded and approved. Can you merge it?

@lhotari lhotari merged commit 2f9eefe into apache:master Dec 13, 2023
19 checks passed
@asafm asafm deleted the pip-metrics-scaffolding branch December 13, 2023 19:27
@Technoboy- Technoboy- added this to the 3.2.0 milestone Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs type/PIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants