[ISSUE #54 #50] Operator multiple mq cluster && start sequence #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linjiemiao
commented
Sep 22, 2020
linjiemiao
commented
- ensure rocketmq-operator can operator more than one rocketmq cluster;
- make sure nameserver must ready before broker cluster.
2. make sure nameserver must ready before broker cluster.
liuruiyiyang
changed the title
| @@ -38,6 +38,8 @@ spec: | |||
| size: 1 | |||
| # nameServers is the [ip:port] list of name service | |||
| nameServers: "" | |||
| # rocketMQName is the rocketmq name, must equal to nameserver.spec.rocketMQName and topictransfer.spec.rocketMQName | |||
There was a problem hiding this comment.
We can not ensure users set insistent name correctly, is there a better way to do this?
There was a problem hiding this comment.
I did this because we don't have a rocketmq resource as the parent resource of the broker and nameserver. Without a common parent controller, we can only specify the connection of the child resource in the spec. So I hope to add a rocketmq api.
There was a problem hiding this comment.
In that case should we add rocketmq higher level api before this PR?
|
still need this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.