Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #5040] Optimize AutoSwitchHAService#truncateInvalidMsg logic #5041

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

mxsm
Copy link
Member

@mxsm mxsm commented Sep 10, 2022

Make sure set the target branch to develop

What is the purpose of the change

close #5040

Brief changelog

  • Optimize AutoSwitchHAService#truncateInvalidMsg logic

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2022

Codecov Report

Merging #5041 (dbbc3e1) into develop (f8bf7bd) will increase coverage by 0.07%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #5041      +/-   ##
=============================================
+ Coverage      43.21%   43.29%   +0.07%     
- Complexity      7764     7770       +6     
=============================================
  Files            995      995              
  Lines          69113    69113              
  Branches        9152     9152              
=============================================
+ Hits           29869    29921      +52     
+ Misses         35490    35437      -53     
- Partials        3754     3755       +1     
Impacted Files Coverage Δ
...ketmq/store/ha/autoswitch/AutoSwitchHAService.java 56.06% <0.00%> (ø)
...ache/rocketmq/common/stats/MomentStatsItemSet.java 39.13% <0.00%> (-4.35%) ⬇️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 81.42% <0.00%> (-1.91%) ⬇️
...ava/org/apache/rocketmq/filter/util/BitsArray.java 58.11% <0.00%> (-1.71%) ⬇️
...mq/client/impl/consumer/RebalanceLitePullImpl.java 69.86% <0.00%> (-1.37%) ⬇️
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 68.75% <0.00%> (-1.10%) ⬇️
.../org/apache/rocketmq/store/ha/DefaultHAClient.java 61.02% <0.00%> (-0.52%) ⬇️
...he/rocketmq/client/impl/consumer/ProcessQueue.java 61.92% <0.00%> (-0.46%) ⬇️
...nt/impl/consumer/ConsumeMessageOrderlyService.java 49.82% <0.00%> (-0.36%) ⬇️
... and 12 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@RongtongJin RongtongJin merged commit 2298d9b into apache:develop Sep 13, 2022
@mxsm mxsm deleted the rocketmq-5040 branch September 13, 2022 12:30
@duhenglucky duhenglucky added this to the 5.0.0 milestone Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize AutoSwitchHAService#truncateInvalidMsg logic
6 participants