[ISSUE #3905] Support bname in protocol for 4.9.x client #5161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drpmma
force-pushed
the
feature/bname
branch
from
e34df5e
to
7be7ee5
Compare
lizhanhui
reviewed
Sep 22, 2022
| @@ -173,6 +173,7 @@ private PushReplyResult pushReplyMessage(final ChannelHandlerContext ctx, | |||
| replyMessageRequestHeader.setProperties(requestHeader.getProperties()); | |||
| replyMessageRequestHeader.setReconsumeTimes(requestHeader.getReconsumeTimes()); | |||
| replyMessageRequestHeader.setUnitMode(requestHeader.isUnitMode()); | |||
| replyMessageRequestHeader.setBname(requestHeader.getBname()); | |||
There was a problem hiding this comment.
bname is arcane and inconsistent with the existing field naming convention. Why not use brokerName?
lizhanhui
reviewed
Sep 22, 2022
| @@ -173,6 +173,7 @@ private PushReplyResult pushReplyMessage(final ChannelHandlerContext ctx, | |||
| replyMessageRequestHeader.setProperties(requestHeader.getProperties()); | |||
| replyMessageRequestHeader.setReconsumeTimes(requestHeader.getReconsumeTimes()); | |||
| replyMessageRequestHeader.setUnitMode(requestHeader.isUnitMode()); | |||
| replyMessageRequestHeader.setBname(requestHeader.getBname()); | |||
There was a problem hiding this comment.
bname is arcane and inconsistent with the existing field naming convention. Why not use brokerName?
There was a problem hiding this comment.
It's backport from 5.0 branch. The bname field is introduced by b6ff649.
xdkxlk
reviewed
Sep 26, 2022
...on/src/main/java/org/apache/rocketmq/common/protocol/header/EndTransactionRequestHeader.java
Show resolved
Hide resolved
...main/java/org/apache/rocketmq/common/protocol/header/CheckTransactionStateRequestHeader.java
Show resolved
Hide resolved
drpmma
force-pushed
the
feature/bname
branch
from
7be7ee5
to
917bc93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Backport 5.0 bname protocol for 4.9.x client
Brief changelog
See this issue for more information