Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #6926] Fixing the error in the initialization order of replicasManager caused the controller mode to fail to start. #6927

Merged
merged 2 commits into from
Jun 23, 2023

Conversation

RongtongJin
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #6926

Brief Description

Fixing the error in the initialization order of replicasManager caused the controller mode to fail to start.

How Did You Test This Change?

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #6927 (f04e2b8) into develop (4e09a9c) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #6927      +/-   ##
=============================================
+ Coverage      42.61%   42.62%   +0.01%     
- Complexity      9173     9176       +3     
=============================================
  Files           1131     1131              
  Lines          80225    80224       -1     
  Branches       10469    10468       -1     
=============================================
+ Hits           34184    34193       +9     
+ Misses         41767    41758       -9     
+ Partials        4274     4273       -1     
Impacted Files Coverage Δ
...a/org/apache/rocketmq/broker/BrokerController.java 44.01% <0.00%> (+0.04%) ⬆️

... and 11 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@RongtongJin RongtongJin merged commit 82492a6 into apache:develop Jun 23, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Fail to start broker in controller mode in 5.1.2
4 participants