Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #6964] use the correct context in telemetry; polish the code structure #6965

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

xdkxlk
Copy link
Contributor

@xdkxlk xdkxlk commented Jun 29, 2023

Which Issue(s) This PR Fixes

Fixes #6964

Brief Description

How Did You Test This Change?

@xdkxlk xdkxlk marked this pull request as draft June 29, 2023 05:53
@codecov-commenter
Copy link

Codecov Report

Merging #6965 (78e21b3) into develop (87075c2) will decrease coverage by 0.05%.
The diff coverage is 18.64%.

@@              Coverage Diff              @@
##             develop    #6965      +/-   ##
=============================================
- Coverage      42.69%   42.65%   -0.05%     
- Complexity      9221     9223       +2     
=============================================
  Files           1131     1131              
  Lines          80485    80495      +10     
  Branches       10520    10517       -3     
=============================================
- Hits           34366    34334      -32     
- Misses         41822    41871      +49     
+ Partials        4297     4290       -7     
Impacted Files Coverage Δ
...etmq/proxy/grpc/v2/DefaultGrpcMessingActivity.java 0.00% <0.00%> (ø)
...cketmq/proxy/grpc/v2/GrpcMessagingApplication.java 38.91% <0.00%> (ø)
...ache/rocketmq/proxy/processor/ClientProcessor.java 0.00% <ø> (ø)
...tmq/proxy/processor/DefaultMessagingProcessor.java 2.89% <0.00%> (ø)
...e/rocketmq/proxy/processor/MessagingProcessor.java 16.66% <ø> (ø)
...proxy/remoting/activity/ClientManagerActivity.java 0.00% <0.00%> (ø)
...oxy/remoting/activity/ConsumerManagerActivity.java 0.00% <0.00%> (ø)
...proxy/remoting/channel/RemotingChannelManager.java 90.69% <ø> (ø)
...q/remoting/protocol/body/LockBatchRequestBody.java 0.00% <0.00%> (ø)
...remoting/protocol/body/UnlockBatchRequestBody.java 0.00% <0.00%> (ø)
... and 6 more

... and 22 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xdkxlk xdkxlk marked this pull request as ready for review June 29, 2023 07:24
Copy link
Contributor

@drpmma drpmma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xdkxlk xdkxlk merged commit bbbe737 into apache:develop Jun 29, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] The context created in telemetry is not right
3 participants