Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7042] TlsTest's serverRejectsSSLClient test case will throw TooLongFrameException #7050

Closed
wants to merge 1 commit into from

Conversation

yao-wenbin
Copy link
Contributor

…tsSSLClient test case will throw TooLongFrameException

Which Issue(s) This PR Fixes

Fixes #7042

Brief Description

In the disabled TLS mode Server, it will not reject the request directly and then request contain SSL cert will cause TooLongFrameException in the NettyDecoder.

more detail see #7042

How Did You Test This Change?

To conform to the semantics of the disable mode, I test the change in two case:

  1. when server in disabled mode, then client send ssl request to server. and then server will reject the request.
  2. when server in disabled mode, then client send no auth request to server. and then server will accept the request.

…tsSSLClient test case will throw TooLongFrameException
@codecov-commenter
Copy link

Codecov Report

Merging #7050 (598a6f3) into develop (440be1e) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

@@              Coverage Diff              @@
##             develop    #7050      +/-   ##
=============================================
- Coverage      42.62%   42.61%   -0.01%     
  Complexity      9230     9230              
=============================================
  Files           1136     1136              
  Lines          80652    80668      +16     
  Branches       10542    10545       +3     
=============================================
+ Hits           34375    34377       +2     
- Misses         41981    41993      +12     
- Partials        4296     4298       +2     
Impacted Files Coverage Δ
...rocketmq/broker/processor/PopMessageProcessor.java 44.74% <0.00%> (ø)
.../java/org/apache/rocketmq/common/BrokerConfig.java 27.28% <25.00%> (-0.02%) ⬇️
...e/rocketmq/remoting/netty/NettyRemotingServer.java 58.23% <100.00%> (ø)

... and 17 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yao-wenbin yao-wenbin changed the title [ISSUE #7042] maven-compile job failed, Because TlsTest's serverRejectsSSLClient test case will throw TooLongFrameException [ISSUE #7042] TlsTest's serverRejectsSSLClient test case will throw TooLongFrameException Jul 21, 2023
@yao-wenbin
Copy link
Contributor Author

@mxsm @lizhimins Hey~ would you guys help me to merge this pull request to repository? I see this PR stalled here for 3 week already.

@yao-wenbin yao-wenbin closed this by deleting the head repository Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] TlsTest's serverRejectsSSLClient test case will throw TooLongFrameException
4 participants