Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: npe in lockBatchMQ and unlockBatchMQ #7078

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

qianye1001
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #issue_id
#7075

Brief Description

Set addressableMessageQueueSet = buildAddressableSet(ctx, mqSet);

addressableMessageQueueSet can be null when Function buildAddressableSet catch exception

Map<String, List> messageQueueSetMap = buildAddressableMapByBrokerName(addressableMessageQueueSet);

in function buildAddressableMapByBrokerName, null will cause NTE

print log and do not add null to addressableMessageQueueSet

How Did You Test This Change?

Copy link
Contributor

@xdkxlk xdkxlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xdkxlk xdkxlk merged commit 3102758 into apache:develop Jul 25, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants