Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] support refresh the config of syncer without redeploy servicec… #1468

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

[feat] support refresh the config of syncer without redeploy servicec… #1468

wants to merge 1 commit into from

Conversation

tornado-ssy
Copy link
Contributor

…omb-center

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run go build go test go fmt go vet to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.
  • Never comment source code, delete it.
  • UT should has "context, subject, expected result" result as test case name, when you call t.Run().

little-cui
little-cui requested changes Apr 13, 2024
View reviewed changes
syncer/config/config.go Outdated
@@ -68,6 +69,20 @@ func Reload() error {
return nil
}

func ReloadConfig() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

补充UT

syncer/config/config.go Outdated
peer.Kind = val["kind"].(string)
peer.Endpoints = val["endpoints"].([]string)
peer.Mode = val["mode"].([]string)
config.Sync.Peers = append(config.Sync.Peers, peer)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果发生变化，打印WARN日志

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@little-cui little-cui little-cui requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tornado-ssy @little-cui