Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1424] [Enhancement] Made Jakarta EE IniEnvironment more flexible #1425

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

lprimak
Copy link
Contributor

@lprimak lprimak commented Apr 19, 2024

Added support for custom SecurityManager implementations.

  • Moved unwrapSecurityManager into ShiroFilter and made it public
  • Easily override EE IniEnvironment to override SecurityManager implementation

fixes #1424

Following this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GitHub issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a GitHub issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [#XXX] - Fixes bug in SessionManager,
    where you replace #XXX with the appropriate GitHub issue. Best practice
    is to use the GitHub issue title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • add fixes #XXX if merging the PR should close a related issue.
  • Run mvn verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.
  • Committers: Make sure a milestone is set on the PR

Trivial changes like typos do not require a GitHub issue (javadoc, comments...).
In this case, just format the pull request title like [DOC] - Add javadoc in SessionManager.

If this is your first contribution, you have to read the Contribution Guidelines

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

…erride SecurityManager implementation in EE IniEnvironment
@lprimak lprimak added java Pull requests that update Java code CLA jakartaee Jakarta EE labels Apr 19, 2024
@lprimak lprimak added this to the 2.0.1 milestone Apr 19, 2024
@lprimak lprimak self-assigned this Apr 19, 2024
@lprimak lprimak changed the title [#1424] [Enhancement] Made Jakarta EE IniEnvironment more adaptable [#1424] [Enhancement] Made Jakarta EE IniEnvironment more flexible Apr 19, 2024
Copy link
Member

@bdemers bdemers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 (with minor comment)

…hod and unwrapSecurityManager() is generic so casting is avoided
@lprimak lprimak merged commit 10bb454 into apache:main Apr 19, 2024
22 checks passed
@lprimak lprimak deleted the adaptable-ee-ini-env branch April 19, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA jakartaee Jakarta EE java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Jakarta EE module configuration is not flexible enough
2 participants