Refactor sonnx, test cases and examples #703

joddiy · 2020-05-18T08:11:04Z

todo-list:

~~sonnx to suit new API(almost done),~~
~~sonnx to use new autograd API,~~
~~test cases,~~
~~debug test operations,~~
~~debug sonnx backend test cases,~~
~~examples~~
~~add re-training examples~~
(if time is enough) add more example(will move to another PR)

lgtm-com · 2020-05-18T08:18:39Z

This pull request introduces 7 alerts when merging b6a8754 into db1846d - view on LGTM.com

new alerts:

3 for Unused local variable
3 for Unreachable code
1 for Unused import

examples/cnn/onnx/train.py

lgtm-com · 2020-05-18T17:40:16Z

This pull request introduces 10 alerts and fixes 13 when merging 7e47512 into db1846d - view on LGTM.com

new alerts:

3 for Unused local variable
3 for Unreachable code
1 for Unnecessary pass
1 for Unused import
1 for Missing call to __init__ during object initialization
1 for Wrong number of arguments in a class instantiation

fixed alerts:

8 for Missing call to __init__ during object initialization
2 for Unreachable code
1 for Unnecessary pass
1 for Unused local variable
1 for Mismatch between signature and use of an overridden method

lgtm-com · 2020-05-18T18:49:49Z

This pull request introduces 10 alerts and fixes 13 when merging 5fccbba into db1846d - view on LGTM.com

new alerts:

3 for Unused local variable
3 for Unreachable code
1 for Unnecessary pass
1 for Unused import
1 for Missing call to __init__ during object initialization
1 for Wrong number of arguments in a class instantiation

fixed alerts:

8 for Missing call to __init__ during object initialization
2 for Unreachable code
1 for Unnecessary pass
1 for Unused local variable
1 for Mismatch between signature and use of an overridden method

lgtm-com · 2020-05-19T20:44:08Z

This pull request introduces 5 alerts and fixes 1 when merging 8849982 into db1846d - view on LGTM.com

new alerts:

4 for Duplicate key in dict literal
1 for Unused local variable

fixed alerts:

1 for Unused local variable

lgtm-com · 2020-05-21T18:47:23Z

This pull request introduces 7 alerts and fixes 1 when merging 54458cb into 84de1af - view on LGTM.com

new alerts:

4 for Duplicate key in dict literal
2 for Unused local variable
1 for Wrong number of arguments in a class instantiation

fixed alerts:

1 for Unused local variable

lgtm-com · 2020-05-22T20:10:55Z

This pull request introduces 7 alerts and fixes 1 when merging cfa8878 into 84de1af - view on LGTM.com

new alerts:

4 for Duplicate key in dict literal
2 for Unused local variable
1 for Wrong number of arguments in a class instantiation

fixed alerts:

1 for Unused local variable

lgtm-com · 2020-05-22T20:23:04Z

This pull request introduces 7 alerts and fixes 1 when merging 03c28ca into 84de1af - view on LGTM.com

new alerts:

4 for Duplicate key in dict literal
2 for Unused local variable
1 for Wrong number of arguments in a class instantiation

fixed alerts:

1 for Unused local variable

lgtm-com · 2020-05-27T20:17:41Z

This pull request introduces 2 alerts and fixes 1 when merging 27051ae into bec1964 - view on LGTM.com

new alerts:

2 for Unused local variable

fixed alerts:

1 for Unused local variable

lgtm-com · 2020-05-28T19:25:17Z

This pull request introduces 2 alerts and fixes 1 when merging 70a0d7e into bec1964 - view on LGTM.com

new alerts:

2 for Unused local variable

fixed alerts:

1 for Unused local variable

lgtm-com · 2020-05-29T15:44:30Z

This pull request introduces 1 alert and fixes 1 when merging 486e1d6 into bec1964 - view on LGTM.com

new alerts:

1 for Unused local variable

fixed alerts:

1 for Unused local variable

lgtm-com · 2020-05-29T18:08:59Z

This pull request introduces 15 alerts and fixes 1 when merging f83b286 into bec1964 - view on LGTM.com

new alerts:

14 for Unused import
1 for Unused local variable

fixed alerts:

1 for Unused local variable

lgtm-com · 2020-05-30T12:54:55Z

This pull request introduces 11 alerts and fixes 1 when merging 223b9e3 into dd18aff - view on LGTM.com

new alerts:

10 for Unused import
1 for Unused local variable

fixed alerts:

1 for Unused local variable

lgtm-com · 2020-05-30T13:04:55Z

This pull request introduces 3 alerts and fixes 1 when merging 7e5bf26 into dd18aff - view on LGTM.com

new alerts:

3 for Unused import

fixed alerts:

1 for Unused local variable

lgtm-com · 2020-05-30T13:32:18Z

This pull request fixes 1 alert when merging fb76557 into dd18aff - view on LGTM.com

fixed alerts:

1 for Unused local variable

lgtm-com · 2020-05-31T06:23:16Z

This pull request fixes 1 alert when merging 44796e6 into dd18aff - view on LGTM.com

fixed alerts:

1 for Unused local variable

nudles · 2020-05-31T14:20:19Z

python/singa/sonnx.py

+        super(SONNXModel, self).__init__()
+        self.sg_ir = prepare(onnx_model)
+        for node, operator in self.sg_ir.layers:
+            self.__dict__[node.name] = operator


is each operator here a Layer instance?

No, you can check the dict of _rename_operators, for the normal operator, it creates the operator from the autograd.py, and for the layer operator, it creates it from layer.py.

if operator is not a Layer instance, then the save_states and load_states cannot work, which works by saving the states of the sub-layers.

At Line 2035-2040, the code will check the type of the instance, if it's from autograd, it will call setattr(op, key, value), otherwise will call op.set_states(**states).

lgtm-com · 2020-06-02T15:47:28Z

This pull request fixes 1 alert when merging 00b65b2 into dd18aff - view on LGTM.com

fixed alerts:

1 for Unused local variable

lgtm-com · 2020-06-02T17:08:47Z

This pull request fixes 1 alert when merging e93770b into dd18aff - view on LGTM.com

fixed alerts:

1 for Unused local variable

lgtm-com · 2020-06-05T09:42:15Z

This pull request fixes 1 alert when merging de46a51 into ede4a3e - view on LGTM.com

fixed alerts:

1 for Unused local variable

lgtm-com · 2020-06-05T10:25:47Z

This pull request fixes 1 alert when merging 61e424e into ede4a3e - view on LGTM.com

fixed alerts:

1 for Unused local variable

joddiy · 2020-06-05T10:29:59Z

@nudles ready to merge

lgtm-com · 2020-06-05T10:33:45Z

This pull request fixes 1 alert when merging 6d46112 into ede4a3e - view on LGTM.com

fixed alerts:

1 for Unused local variable

nudles

after we convert onnx model to sonnx model and finish the training, can we save the sonnx model as onnx model?

examples/onnx/arcface.py

lgtm-com · 2020-06-05T12:02:18Z

This pull request fixes 1 alert when merging c563ed3 into ede4a3e - view on LGTM.com

fixed alerts:

1 for Unused local variable

lgtm-com · 2020-06-05T13:45:09Z

This pull request fixes 1 alert when merging 6af18ba into ede4a3e - view on LGTM.com

fixed alerts:

1 for Unused local variable

lgtm-com · 2020-06-05T14:10:23Z

This pull request fixes 1 alert when merging 43addc7 into ede4a3e - view on LGTM.com

fixed alerts:

1 for Unused local variable

nudles reviewed May 18, 2020

View reviewed changes

examples/cnn/onnx/train.py Outdated Show resolved Hide resolved

joddiy force-pushed the sonnx_new_api branch from e4f08a2 to 8849982 Compare May 19, 2020 20:35

joddiy force-pushed the sonnx_new_api branch from 8849982 to 54458cb Compare May 21, 2020 18:37

joddiy force-pushed the sonnx_new_api branch from 54458cb to d5c4080 Compare May 22, 2020 20:02

joddiy force-pushed the sonnx_new_api branch from 486e1d6 to f83b286 Compare May 29, 2020 17:55

joddiy force-pushed the sonnx_new_api branch from f83b286 to 223b9e3 Compare May 30, 2020 12:46

joddiy marked this pull request as ready for review May 30, 2020 12:48

joddiy force-pushed the sonnx_new_api branch from 223b9e3 to 7e5bf26 Compare May 30, 2020 12:58

joddiy force-pushed the sonnx_new_api branch from 7e5bf26 to fb76557 Compare May 30, 2020 13:25

joddiy force-pushed the sonnx_new_api branch from fb76557 to 44796e6 Compare May 31, 2020 06:09

nudles reviewed May 31, 2020

View reviewed changes

nudles mentioned this pull request Jun 2, 2020

New Model Layer Operator API #697

Merged

joddiy force-pushed the sonnx_new_api branch from 44796e6 to 00b65b2 Compare June 2, 2020 15:38

joddiy force-pushed the sonnx_new_api branch from 00b65b2 to e93770b Compare June 2, 2020 17:01

joddiy mentioned this pull request Jun 3, 2020

Expand the model zoo (example model set) #700

Open

joddiy force-pushed the sonnx_new_api branch from e93770b to 9e4a252 Compare June 5, 2020 09:26

joddiy force-pushed the sonnx_new_api branch 3 times, most recently from c7b24fc to 61e424e Compare June 5, 2020 10:18

joddiy force-pushed the sonnx_new_api branch from 61e424e to 6d46112 Compare June 5, 2020 10:26

nudles reviewed Jun 5, 2020

View reviewed changes

examples/onnx/arcface.py Outdated Show resolved Hide resolved

joddiy force-pushed the sonnx_new_api branch from 6d46112 to c563ed3 Compare June 5, 2020 11:54

joddiy added 2 commits June 5, 2020 21:37

refactor soonx backend

88ffd81

refactor sonnx test cases

77eaf45

joddiy force-pushed the sonnx_new_api branch from c563ed3 to 6af18ba Compare June 5, 2020 13:38

refactor sonnx examples

43addc7

joddiy force-pushed the sonnx_new_api branch from 6af18ba to 43addc7 Compare June 5, 2020 14:03

nudles merged commit 038e2df into apache:dev Jun 5, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor sonnx, test cases and examples #703

Refactor sonnx, test cases and examples #703

joddiy commented May 18, 2020 •

edited

Loading

lgtm-com bot commented May 18, 2020

lgtm-com bot commented May 18, 2020

lgtm-com bot commented May 18, 2020

lgtm-com bot commented May 19, 2020

lgtm-com bot commented May 21, 2020

lgtm-com bot commented May 22, 2020

lgtm-com bot commented May 22, 2020

lgtm-com bot commented May 27, 2020

lgtm-com bot commented May 28, 2020

lgtm-com bot commented May 29, 2020

lgtm-com bot commented May 29, 2020

lgtm-com bot commented May 30, 2020

lgtm-com bot commented May 30, 2020

lgtm-com bot commented May 30, 2020

lgtm-com bot commented May 31, 2020

nudles May 31, 2020

joddiy May 31, 2020

nudles Jun 1, 2020

joddiy Jun 1, 2020

lgtm-com bot commented Jun 2, 2020

lgtm-com bot commented Jun 2, 2020

lgtm-com bot commented Jun 5, 2020

lgtm-com bot commented Jun 5, 2020

joddiy commented Jun 5, 2020

lgtm-com bot commented Jun 5, 2020

nudles left a comment

lgtm-com bot commented Jun 5, 2020

lgtm-com bot commented Jun 5, 2020

lgtm-com bot commented Jun 5, 2020

Refactor sonnx, test cases and examples #703

Refactor sonnx, test cases and examples #703

Conversation

joddiy commented May 18, 2020 • edited Loading

lgtm-com bot commented May 18, 2020

lgtm-com bot commented May 18, 2020

lgtm-com bot commented May 18, 2020

lgtm-com bot commented May 19, 2020

lgtm-com bot commented May 21, 2020

lgtm-com bot commented May 22, 2020

lgtm-com bot commented May 22, 2020

lgtm-com bot commented May 27, 2020

lgtm-com bot commented May 28, 2020

lgtm-com bot commented May 29, 2020

lgtm-com bot commented May 29, 2020

lgtm-com bot commented May 30, 2020

lgtm-com bot commented May 30, 2020

lgtm-com bot commented May 30, 2020

lgtm-com bot commented May 31, 2020

nudles May 31, 2020

Choose a reason for hiding this comment

joddiy May 31, 2020

Choose a reason for hiding this comment

nudles Jun 1, 2020

Choose a reason for hiding this comment

joddiy Jun 1, 2020

Choose a reason for hiding this comment

lgtm-com bot commented Jun 2, 2020

lgtm-com bot commented Jun 2, 2020

lgtm-com bot commented Jun 5, 2020

lgtm-com bot commented Jun 5, 2020

joddiy commented Jun 5, 2020

lgtm-com bot commented Jun 5, 2020

nudles left a comment

Choose a reason for hiding this comment

lgtm-com bot commented Jun 5, 2020

lgtm-com bot commented Jun 5, 2020

lgtm-com bot commented Jun 5, 2020

joddiy commented May 18, 2020 •

edited

Loading