Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoopSpan on queue full, propagation downstream #141

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

tom-pytel
Copy link
Contributor

@tom-pytel tom-pytel commented Aug 3, 2021

This has two things similar to the Node agent PR 50, it has:

  • Spans which are ignored due to suffix or endpoint name pattern match will propagate their ignored status downstream via noop span and sending an empty "sw8" header. If such an empty header is received then a dummy context and span is created instead of a new actively traced segment. This is only a behavior change for this agent and is compatible with other language agents, they will just act as they have always done. The Node agent already has this behavior so will ignore spans ignored by this agent and vice-versa.
  • The method of limiting the number of segments which are recorded has been changed from post-record check to pre-record check to avoid unnecessary instrumentation if the number of segments already exceeds the threshold and the data would be thrown away anyway. This also allows propagation of ignored status of segment downstream via mechanism described above to avoid broken "VNode" segments in trace view.

And the minor little detail in sw_urllib_request, the change from:

[fullurl.add_header(item.key, item.val) for item in carrier]

To:

for item in carrier:
    fullurl.add_header(item.key, item.val)

The first form is not ideal since it actually creates the intermediate list object from the comprehension unnecessarily.

@tom-pytel tom-pytel added the enhancement New feature or request label Aug 3, 2021
@tom-pytel tom-pytel added this to the 0.7.0 milestone Aug 3, 2021
@kezhenxu94 kezhenxu94 merged commit 4a96ff8 into apache:master Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants