[SPARK-40859][INFRA] Upgrade action/checkout to v3 to cleanup warning #38322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yikun
commented
Oct 20, 2022
| @@ -37,7 +37,7 @@ jobs: | |||
| - branch-3.1 | |||
| steps: | |||
| - name: Checkout Spark repository | |||
| uses: actions/checkout@61b9e3751b92087fd0b06925ba6dd6314e06f089 # pin@master | |||
| uses: actions/checkout@v3 | |||
There was a problem hiding this comment.
I also take a look on 00b87c9, I think pin SHA is only for 3rd party, but for actions/ I think tag is enough. BTW, the note is already outdate.
srowen
approved these changes
Oct 20, 2022
HyukjinKwon
approved these changes
Oct 21, 2022
|
@srowen @HyukjinKwon Thanks, merged. |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
### What changes were proposed in this pull request? Upgrade action/checkout to v3 (point ot v3.1 now). ### Why are the changes needed? - https://github.com/actions/checkout/releases/tag/v3.1.0 cleanup "[The 'set-output' command is deprecated and will be disabled soon.](actions/checkout#959 (comment))" - https://github.com/actions/checkout/releases/tag/v3.0.0 since v3, use the node 16 to cleanup "[Node.js 12 actions are deprecated](https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/)" According to actions/checkout#959 (comment), v2.5 also address 'set-output' warning, but only v3 support node 16, so we upgrade to v3.1 rather than v2.5 ### Does this PR introduce _any_ user-facing change? No, dev only ### How was this patch tested? CI passed Closes apache#38322 from Yikun/checkout-v3. Authored-by: Yikun Jiang <yikunkero@gmail.com> Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Upgrade action/checkout to v3 (point ot v3.1 now).
Why are the changes needed?
According to actions/checkout#959 (comment), v2.5 also address 'set-output' warning, but only v3 support node 16, so we upgrade to v3.1 rather than v2.5
Does this PR introduce any user-facing change?
No, dev only
How was this patch tested?
CI passed