[SPARK-44548][PYTHON] Add support for pandas-on-Spark DataFrame assertDataFrameEqual #42158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
changed the title
asl3
changed the title
|
@itholic I think you should review this. |
itholic
reviewed
Jul 27, 2023
itholic
approved these changes
Jul 28, 2023
|
Looks pretty good. cc @HyukjinKwon for confirming as CI is passed |
HyukjinKwon
approved these changes
Jul 28, 2023
|
Merged to master and branch-3.5. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Jul 28, 2023
…tDataFrameEqual ### What changes were proposed in this pull request? This PR adds support for pandas-on-Spark DataFrame for the testing util, `assertDataFrameEqual` ### Why are the changes needed? The change allows users to call the same PySpark API for both Spark and pandas DataFrames. ### Does this PR introduce _any_ user-facing change? Yes, the PR affects the user-facing util `assertDataFrameEqual` ### How was this patch tested? Added tests to `python/pyspark/sql/tests/test_utils.py` and `python/pyspark/sql/tests/connect/test_utils.py` and existing pandas util tests. Closes #42158 from asl3/pandas-or-pyspark-df. Authored-by: Amanda Liu <amanda.liu@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 7c1ad5b) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
ragnarok56
pushed a commit
to ragnarok56/spark
that referenced
this pull request
Mar 2, 2024
…tDataFrameEqual ### What changes were proposed in this pull request? This PR adds support for pandas-on-Spark DataFrame for the testing util, `assertDataFrameEqual` ### Why are the changes needed? The change allows users to call the same PySpark API for both Spark and pandas DataFrames. ### Does this PR introduce _any_ user-facing change? Yes, the PR affects the user-facing util `assertDataFrameEqual` ### How was this patch tested? Added tests to `python/pyspark/sql/tests/test_utils.py` and `python/pyspark/sql/tests/connect/test_utils.py` and existing pandas util tests. Closes apache#42158 from asl3/pandas-or-pyspark-df. Authored-by: Amanda Liu <amanda.liu@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds support for pandas-on-Spark DataFrame for the testing util,
assertDataFrameEqualWhy are the changes needed?
The change allows users to call the same PySpark API,
assertDataFrameEqual, for both Spark and pandas-on-Spark DataFrames. It also exposes a new user-facing API,assertPandasOnSparkEqual.Does this PR introduce any user-facing change?
Yes, the PR affects the user-facing util
assertDataFrameEqualand exposes a new user-facing API,assertPandasOnSparkEqual.How was this patch tested?
Added tests to
python/pyspark/sql/tests/test_utils.pyandpython/pyspark/sql/tests/connect/test_utils.pyand existing pandas util tests.