[SPARK-48760][SQL] Fix CatalogV2Util.applyClusterByChanges #47288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zedtang
commented
Jul 10, 2024
| s"$defaultUsing CLUSTER BY (col1, col2.x)") | ||
| sql(s"ALTER TABLE $tbl ALTER COLUMN col1 COMMENT 'this is comment';") | ||
| val descriptionDf = sql(s"DESC $tbl") | ||
| assert(descriptionDf.schema.map(field => (field.name, field.dataType)) === Seq( | ||
| ("col_name", StringType), |
There was a problem hiding this comment.
This updated test would fail without the fix.
|
Hi @cloud-fan , @imback82 , @dabao521, this PR is ready for review, thanks! |
cloud-fan
approved these changes
Jul 12, 2024
|
thanks, merging to master! |
jingz-db
pushed a commit
to jingz-db/spark
that referenced
this pull request
Jul 22, 2024
### What changes were proposed in this pull request? apache#47156 introduced a bug in `CatalogV2Util.applyClusterByChanges` that it will remove the existing `ClusterByTransform` first, regardless of whether there is a `ClusterBy` table change. This means any table change will remove the clustering columns from the table. This PR fixes the bug by removing the `ClusterByTransform` only when there is a `ClusterBy` table change. ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Amend existing test to catch this bug. ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#47288 from zedtang/fix-apply-cluster-by-changes. Authored-by: Jiaheng Tang <jiaheng.tang@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
#47156 introduced a bug in
CatalogV2Util.applyClusterByChangesthat it will remove the existingClusterByTransformfirst, regardless of whether there is aClusterBytable change. This means any table change will remove the clustering columns from the table.This PR fixes the bug by removing the
ClusterByTransformonly when there is aClusterBytable change.Why are the changes needed?
Does this PR introduce any user-facing change?
No
How was this patch tested?
Amend existing test to catch this bug.
Was this patch authored or co-authored using generative AI tooling?
No