Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-49741][DOCS] Add spark.shuffle.accurateBlockSkewedFactor to config docs page #48189

Closed
wants to merge 3 commits into from
Closed

[SPARK-49741][DOCS] Add spark.shuffle.accurateBlockSkewedFactor to config docs page #48189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d4d6bc
add config
timlee0119 Sep 20, 2024
8c59fc6
move config location
timlee0119 Sep 20, 2024
0e9ac02
remove internal
timlee0119 Sep 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion core/src/main/scala/org/apache/spark/internal/config/package.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1357,7 +1357,6 @@ package object config {

private[spark] val SHUFFLE_ACCURATE_BLOCK_SKEWED_FACTOR =
ConfigBuilder("spark.shuffle.accurateBlockSkewedFactor")
.internal()
.doc("A shuffle block is considered as skewed and will be accurately recorded in " +
"HighlyCompressedMapStatus if its size is larger than this factor multiplying " +
"the median shuffle block size or SHUFFLE_ACCURATE_BLOCK_THRESHOLD. It is " +
Expand Down
13 changes: 13 additions & 0 deletions docs/configuration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1222,6 +1222,19 @@ Apart from these, the following properties are also available, and may be useful
</td>
<td>2.2.1</td>
</tr>
<tr>
<td><code>spark.shuffle.accurateBlockSkewedFactor</code></td>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To @timlee0119 and @JoshRosen , shall we remove .internal() from the configuration definition together?

spark/core/src/main/scala/org/apache/spark/internal/config/package.scala

Lines 1387 to 1389 in bdea091

private[spark] val SHUFFLE_ACCURATE_BLOCK_SKEWED_FACTOR =
ConfigBuilder("spark.shuffle.accurateBlockSkewedFactor")
.internal()

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition, the PR title looks wrong to me because we are touching spark.shuffle.accurateBlockSkewedFactor instead of spark.sql.adaptive.....

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I would match the description

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the typo, I've fixed the PR title and removed internal()

<td>-1.0</td>
<td>
A shuffle block is considered as skewed and will be accurately recorded in
<code>HighlyCompressedMapStatus</code> if its size is larger than this factor multiplying
the median shuffle block size or <code>spark.shuffle.accurateBlockThreshold</code>. It is
recommended to set this parameter to be the same as
<code>spark.sql.adaptive.skewJoin.skewedPartitionFactor</code>. Set to -1.0 to disable this
feature by default.
</td>
<td>3.3.0</td>
</tr>
<tr>
<td><code>spark.shuffle.registration.timeout</code></td>
<td>5000</td>
Expand Down