Skip to content
This repository has been archived by the owner on Jul 10, 2024. It is now read-only.

SUBMARINE-1296. Add create user function when register a new user. #1012

Closed
wants to merge 1 commit into from

Conversation

hhcs9527
Copy link
Contributor

@hhcs9527 hhcs9527 commented Nov 5, 2022

What is this PR for?

Originally we were unable to create a user correctly; We add create user function when registering a new user in this PR.

What type of PR is it?

[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]
Bug Fix

Future work

  • When we log in to the account, it always shows adim in the userInfo
  • Remove the mock data in here

What is the Jira issue?

SUBMARINE-1293

How should this be tested?

Screenshots (if appropriate)

  • When you haven't created such a user

image

  • When you save duplicated username

image

  • Done creation and log in again

Questions:

  • Do the license files need updating? No
  • Are there breaking changes for older versions? No
  • Does this need new documentation? No

@codecov
Copy link

codecov bot commented Nov 5, 2022

Codecov Report

Merging #1012 (e118d81) into master (bc4bf08) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1012   +/-   ##
=========================================
  Coverage     25.47%   25.47%           
  Complexity     1079     1079           
=========================================
  Files           358      358           
  Lines         29088    29088           
  Branches       3479     3479           
=========================================
  Hits           7411     7411           
  Misses        21463    21463           
  Partials        214      214           
Flag Coverage Δ
python-integration 59.58% <ø> (ø)
python-unit 52.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hhcs9527 hhcs9527 marked this pull request as draft November 6, 2022 04:09
@hhcs9527 hhcs9527 marked this pull request as ready for review November 6, 2022 04:09
@hhcs9527
Copy link
Contributor Author

hhcs9527 commented Nov 6, 2022

@cdmikechen please take a look at the pr, thanks
I can't add reviewer due to permission issue.

@pingsutw pingsutw self-requested a review November 8, 2022 04:57
Copy link
Contributor

@cdmikechen cdmikechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest that we can show the changed result under the screenshot.
Others LGTM

@asfgit asfgit closed this in dd6a292 Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants