Skip to content
This repository has been archived by the owner on Jul 10, 2024. It is now read-only.

SUBMARINE-1293. Move seldon-core install to helm #999

Closed
wants to merge 8 commits into from

Conversation

hhcs9527
Copy link
Contributor

@hhcs9527 hhcs9527 commented Sep 28, 2022

What is this PR for?

Move seldon-core install to helm

What type of PR is it?

[Bug Fix]

Todos

What is the Jira issue?

https://issues.apache.org/jira/browse/SUBMARINE-1293

How should this be tested?

Make sure we can install the sekdon-core correctly.

Screenshots (if appropriate)

Questions:

  • Do the license files need updating? No
  • Are there breaking changes for older versions? No
  • Does this need new documentation? No

@cdmikechen
Copy link
Contributor

cdmikechen commented Sep 28, 2022

Hi~ @hhcs9527
Thanks for your contribution. I've left some comments that may need to be modified and I'll verify the deployment later.

helm-charts/submarine/Chart.yaml Outdated Show resolved Hide resolved
@cdmikechen cdmikechen changed the title SUBMARINE-1296. Move seldon-core install to helm SUBMARINE-1293. Move seldon-core install to helm Sep 29, 2022
Copy link
Contributor

@cdmikechen cdmikechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hhcs9527
Hi. What I thought was that we did not need to deal with submarine-serve/installation/seldon-secret.yaml for the time being.
Also, the namespace of the gateway needs to be the same as the helm install namespace.

I'll turn on github workflow when this part is fixed, there may still be issues to resolve when running test cases, and I will help you with this part when the time comes.

@hhcs9527
Copy link
Contributor Author

hhcs9527 commented Oct 5, 2022

@hhcs9527 Hi. What I thought was that we did not need to deal with submarine-serve/installation/seldon-secret.yaml for the time being. Also, the namespace of the gateway needs to be the same as the helm install namespace.

I'll turn on github workflow when this part is fixed, there may still be issues to resolve when running test cases, and I will help you with this part when the time comes.

I think I misunderstand your meaning. I am sorry.
Many thanks for your help on this.

@hhcs9527 hhcs9527 force-pushed the SUBMARINE-1293 branch 3 times, most recently from 4b54b11 to 10482d5 Compare October 10, 2022 13:39
helm-charts/submarine/templates/seldon-gateway.yaml Outdated Show resolved Hide resolved
helm-charts/submarine/Chart.yaml Show resolved Hide resolved
helm-charts/submarine/templates/seldon-secret.yaml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 15, 2022

Codecov Report

Merging #999 (0b321ca) into master (67fe91f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #999   +/-   ##
=========================================
  Coverage     25.46%   25.46%           
  Complexity     1079     1079           
=========================================
  Files           358      358           
  Lines         29078    29078           
  Branches       3479     3479           
=========================================
  Hits           7404     7404           
  Misses        21460    21460           
  Partials        214      214           
Flag Coverage Δ
python-integration 59.58% <ø> (ø)
python-unit 52.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@cdmikechen cdmikechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for your efforts on this PR

@asfgit asfgit closed this in 9bf57a3 Oct 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants