-
Notifications
You must be signed in to change notification settings - Fork 254
SUBMARINE-1293. Move seldon-core install to helm #999
Conversation
Hi~ @hhcs9527 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hhcs9527
Hi. What I thought was that we did not need to deal with submarine-serve/installation/seldon-secret.yaml
for the time being.
Also, the namespace of the gateway needs to be the same as the helm install namespace.
I'll turn on github workflow when this part is fixed, there may still be issues to resolve when running test cases, and I will help you with this part when the time comes.
I think I misunderstand your meaning. I am sorry. |
4b54b11
to
10482d5
Compare
…lue for synchronization
…lue for synchronization
10482d5
to
a2b4cda
Compare
Codecov Report
@@ Coverage Diff @@
## master #999 +/- ##
=========================================
Coverage 25.46% 25.46%
Complexity 1079 1079
=========================================
Files 358 358
Lines 29078 29078
Branches 3479 3479
=========================================
Hits 7404 7404
Misses 21460 21460
Partials 214 214
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for your efforts on this PR
What is this PR for?
Move seldon-core install to helm
What type of PR is it?
[Bug Fix]
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-1293
How should this be tested?
Make sure we can install the sekdon-core correctly.
Screenshots (if appropriate)
Questions: