Add support for linking directly to Create Dataset modal via URL hash.

apache · Jun 17, 2022 · 0857a5f · 0857a5f
1 parent 3626c53
commit 0857a5f
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 2 deletions.
diff --git a/superset-frontend/src/addSlice/AddSliceContainer.tsx b/superset-frontend/src/addSlice/AddSliceContainer.tsx
@@ -314,7 +314,7 @@ export default class AddSliceContainer extends React.PureComponent<
                 />
                 <span>
                   <a
-                    href="/tablemodelview/list"
+                    href="/tablemodelview/list/#create"
                     rel="noopener noreferrer"
                     target="_blank"
                   >

diff --git a/superset-frontend/src/views/CRUD/data/dataset/DatasetList.test.jsx b/superset-frontend/src/views/CRUD/data/dataset/DatasetList.test.jsx
@@ -183,6 +183,12 @@ describe('DatasetList', () => {
   });
 });
 
+jest.mock('react-router-dom', () => ({
+  ...jest.requireActual('react-router-dom'),
+  useLocation: () => ({}),
+  useHistory: () => ({}),
+}));
+
 describe('RTL', () => {
   async function renderAndWait() {
     const mounted = act(async () => {
@@ -191,7 +197,7 @@ describe('RTL', () => {
         <QueryParamProvider>
           <DatasetList {...mockedProps} user={mockUser} />
         </QueryParamProvider>,
-        { useRedux: true },
+        { useRedux: true, useRouter: true },
       );
     });
 

diff --git a/superset-frontend/src/views/CRUD/data/dataset/DatasetList.tsx b/superset-frontend/src/views/CRUD/data/dataset/DatasetList.tsx
@@ -22,8 +22,10 @@ import React, {
   useState,
   useMemo,
   useCallback,
+  useEffect,
 } from 'react';
 import rison from 'rison';
+import { useHistory, useLocation } from 'react-router-dom';
 import {
   createFetchRelated,
   createFetchDistinct,
@@ -626,6 +628,15 @@ const DatasetList: FunctionComponent<DatasetListProps> = ({
     );
   };
 
+  const location = useLocation();
+  const history = useHistory();
+  useEffect(() => {
+    if (location.hash === '#create' && canCreate) {
+      history.replace(`${location.pathname}${location.search}`);
+      setDatasetAddModalOpen(true);
+    }
+  }, [canCreate, history, location]);
+
   return (
     <>
       <SubMenu {...menuData} />