Skip to content

Commit

Permalink
chore: add test for SPA explore endpoints around missing datasets (#2…
Browse files Browse the repository at this point in the history
  • Loading branch information
hughhhh authored Sep 9, 2022
1 parent d3f9fbb commit 14cd8a2
Show file tree
Hide file tree
Showing 2 changed files with 42 additions and 0 deletions.
12 changes: 12 additions & 0 deletions tests/unit_tests/datasource/dao_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -202,3 +202,15 @@ def test_get_all_datasources(session_with_data: Session) -> None:

result = SqlaTable.get_all_datasources(session=session_with_data)
assert len(result) == 1


def test_not_found_datasource(session_with_data: Session) -> None:
from superset.dao.exceptions import DatasourceNotFound
from superset.datasource.dao import DatasourceDAO

with pytest.raises(DatasourceNotFound):
DatasourceDAO.get_datasource(
datasource_type="table",
datasource_id=500000,
session=session_with_data,
)
30 changes: 30 additions & 0 deletions tests/unit_tests/explore/api_test.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.

from typing import Any

import pytest


def test_explore_datasource_not_found(client: Any, full_api_access: None) -> None:
# validating the payload for a dataset that doesn't exist
# user should be expecting missing_datasource view
response = client.get(
"/api/v1/explore/?dataset_id=50000&dataset_type=table",
)
response.json["result"]["dataset"]["name"] == "[Missing Dataset]"
assert response.status_code == 200

0 comments on commit 14cd8a2

Please sign in to comment.