chore: avoid undefined property on Global type (#21631)

apache · Oct 3, 2022 · 1574829 · 1574829
1 parent ef78ec6
commit 1574829
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/superset-frontend/packages/superset-ui-switchboard/src/switchboard.test.ts b/superset-frontend/packages/superset-ui-switchboard/src/switchboard.test.ts
@@ -105,7 +105,9 @@ describe('comms', () => {
   let originalConsoleError: any = null;
 
   beforeAll(() => {
-    global.MessageChannel = FakeMessageChannel; // yolo
+    Object.defineProperty(global, 'MessageChannel', {
+      value: FakeMessageChannel,
+    });
     originalConsoleDebug = console.debug;
     originalConsoleError = console.error;
   });

diff --git a/superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx b/superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx
@@ -283,7 +283,7 @@ const DashboardBuilder: FC<DashboardBuilderProps> = () => {
     setBarTopOffset(headerRef.current?.getBoundingClientRect()?.height || 0);
 
     let observer: ResizeObserver;
-    if (typeof global.ResizeObserver !== 'undefined' && headerRef.current) {
+    if (global.hasOwnProperty('ResizeObserver') && headerRef.current) {
       observer = new ResizeObserver(entries => {
         setBarTopOffset(
           current => entries?.[0]?.contentRect?.height || current,