test(Native Filter): User can create parent filters using "Filter is …

…hierarchical (#18915) * add new native test for parent filter
apache · Feb 25, 2022 · 2bd8d3b · 2bd8d3b
1 parent 4923256
commit 2bd8d3b
Show file tree

Hide file tree

Showing 2 changed files with 118 additions and 1 deletion.
diff --git a/superset-frontend/cypress-base/cypress/integration/dashboard/nativeFilters.test.ts b/superset-frontend/cypress-base/cypress/integration/dashboard/nativeFilters.test.ts
@@ -22,7 +22,11 @@ import {
   nativeFilters,
   exploreView,
 } from 'cypress/support/directories';
-import { testItems } from './dashboard.helper';
+import {
+  testItems,
+  WORLD_HEALTH_CHARTS,
+  waitForChartLoad,
+} from './dashboard.helper';
 import { DASHBOARD_LIST } from '../dashboard_list/dashboard_list.helper';
 import { CHART_LIST } from '../chart_list/chart_list.helper';
 import { FORM_DATA_DEFAULTS } from '../explore/visualizations/shared.helper';
@@ -542,6 +546,114 @@ describe('Nativefilters Sanity test', () => {
       .contains('year')
       .should('be.visible');
   });
+  it('User can create parent filters using "Filter is hierarchical"', () => {
+    cy.get(nativeFilters.filterFromDashboardView.expand).click({ force: true });
+    // Create region filter
+    cy.get(nativeFilters.filterFromDashboardView.createFilterButton)
+      .should('be.visible')
+      .click();
+    cy.get(nativeFilters.filtersPanel.filterTypeInput)
+      .find(nativeFilters.filtersPanel.filterTypeItem)
+      .click({ force: true });
+    cy.get('[label="Value"]').click();
+    cy.get(nativeFilters.modal.container)
+      .find(nativeFilters.filtersPanel.datasetName)
+      .click({ force: true })
+      .within(() =>
+        cy
+          .get('input')
+          .type('wb_health_population{enter}', { delay: 50, force: true }),
+      );
+    cy.get(nativeFilters.modal.container)
+      .find(nativeFilters.filtersPanel.filterName)
+      .click({ force: true })
+      .clear()
+      .type('region', { scrollBehavior: false, force: true });
+    cy.wait(3000);
+    cy.get(nativeFilters.silentLoading).should('not.exist');
+    cy.get(nativeFilters.filtersPanel.filterInfoInput)
+      .last()
+      .should('be.visible')
+      .click({ force: true });
+    cy.get(nativeFilters.filtersPanel.filterInfoInput).last().type('region');
+    cy.get(nativeFilters.filtersPanel.inputDropdown)
+      .last()
+      .should('be.visible', { timeout: 20000 })
+      .click({ force: true });
+    // Create country filter
+    cy.get(nativeFilters.addFilterButton.button)
+      .first()
+      .click({ force: true })
+      .then(() => {
+        cy.get(nativeFilters.addFilterButton.dropdownItem)
+          .contains('Filter')
+          .click({ force: true });
+      });
+    cy.get(nativeFilters.filtersPanel.filterTypeInput)
+      .find(nativeFilters.filtersPanel.filterTypeItem)
+      .last()
+      .click({ force: true });
+    cy.get('[label="Value"]').last().click({ force: true });
+    cy.get(nativeFilters.modal.container)
+      .find(nativeFilters.filtersPanel.datasetName)
+      .last()
+      .click({ scrollBehavior: false })
+      .within(() =>
+        cy
+          .get('input')
+          .clear({ force: true })
+          .type('wb_health_population{enter}', {
+            delay: 50,
+            force: true,
+            scrollBehavior: false,
+          }),
+      );
+    cy.get(nativeFilters.filtersPanel.filterInfoInput)
+      .last()
+      .should('be.visible')
+      .click({ force: true });
+    cy.get(nativeFilters.filtersPanel.inputDropdown)
+      .should('be.visible', { timeout: 20000 })
+      .last()
+      .click();
+    cy.get(nativeFilters.modal.container)
+      .find(nativeFilters.filtersPanel.filterName)
+      .last()
+      .click({ force: true })
+      .type('country', { scrollBehavior: false, force: true });
+    cy.get(nativeFilters.silentLoading).should('not.exist');
+    cy.get(nativeFilters.filtersPanel.filterInfoInput)
+      .last()
+      .click({ force: true });
+    cy.get(nativeFilters.filtersPanel.filterInfoInput)
+      .last()
+      .type('country_name', { delay: 50, scrollBehavior: false, force: true });
+    cy.get(nativeFilters.filtersPanel.inputDropdown)
+      .last()
+      .should('be.visible', { timeout: 20000 })
+      .click({ force: true });
+    // Setup parent filter
+    cy.get(nativeFilters.filterConfigurationSections.displayedSection).within(
+      () => {
+        cy.contains('Filter is hierarchical').should('be.visible').click();
+        cy.wait(1000);
+        cy.get(nativeFilters.filterConfigurationSections.parentFilterInput)
+          .click()
+          .type('region{enter}', { delay: 30 });
+      },
+    );
+    cy.get(nativeFilters.modal.footer)
+      .contains('Save')
+      .should('be.visible')
+      .click();
+    WORLD_HEALTH_CHARTS.forEach(waitForChartLoad);
+    // assert that native filter is created
+    cy.get(nativeFilters.filterFromDashboardView.filterName)
+      .should('be.visible')
+      .contains('region');
+    cy.get(nativeFilters.filterIcon).click();
+    cy.contains('Select parent filters (2)').should('be.visible');
+  });
 });
 
 xdescribe('Nativefilters', () => {

diff --git a/superset-frontend/cypress-base/cypress/support/directories.ts b/superset-frontend/cypress-base/cypress/support/directories.ts
@@ -327,6 +327,10 @@ export const nativeFilters = {
     addFilter: dataTestLocator('add-filter-button'),
     defaultValueCheck: '.ant-checkbox-checked',
   },
+  addFilterButton: {
+    button: `.ant-modal-content [data-test="new-dropdown-icon"]`,
+    dropdownItem: '.ant-dropdown-menu-item',
+  },
   filtersPanel: {
     filterName: dataTestLocator('filters-config-modal__name-input'),
     datasetName: dataTestLocator('filters-config-modal__datasource-input'),
@@ -350,6 +354,7 @@ export const nativeFilters = {
   removeFilter: '[aria-label="remove"]',
   silentLoading: '.loading inline-centered css-101mkpk',
   filterConfigurationSections: {
+    displayedSection: 'div[style="height: 100%; overflow-y: auto;"]',
     collapseExpandButton: '.ant-collapse-arrow',
     checkedCheckbox: '.ant-checkbox-wrapper-checked',
     infoTooltip: '[aria-label="Show info tooltip"]',