Skip to content

Commit

Permalink
chore: convert URLShortLinkButton to typescript (#19954)
Browse files Browse the repository at this point in the history
  • Loading branch information
ktmud authored May 5, 2022
1 parent 7c3fd06 commit 54bfd83
Show file tree
Hide file tree
Showing 11 changed files with 272 additions and 322 deletions.
73 changes: 0 additions & 73 deletions superset-frontend/src/components/AnchorLink/AnchorLink.test.jsx

This file was deleted.

94 changes: 0 additions & 94 deletions superset-frontend/src/components/AnchorLink/index.jsx

This file was deleted.

120 changes: 0 additions & 120 deletions superset-frontend/src/components/URLShortLinkButton/index.jsx

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export default {
};

export const InteractiveAnchorLink = (args: any) => (
<AnchorLink anchorLinkId="link" {...args} />
<AnchorLink id="link" {...args} />
);

const PLACEMENTS = ['right', 'left', 'top', 'bottom'];
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import React from 'react';
import { render, act } from 'spec/helpers/testing-library';
import AnchorLink from 'src/dashboard/components/AnchorLink';

describe('AnchorLink', () => {
const props = {
id: 'CHART-123',
dashboardId: 10,
};

const globalLocation = window.location;
afterEach(() => {
window.location = globalLocation;
});

it('should scroll the AnchorLink into view upon mount if id matches hash', async () => {
const callback = jest.fn();
jest.spyOn(document, 'getElementById').mockReturnValue({
scrollIntoView: callback,
} as unknown as HTMLElement);

window.location.hash = props.id;
await act(async () => {
render(<AnchorLink {...props} />, { useRedux: true });
});
expect(callback).toHaveBeenCalledTimes(1);

window.location.hash = 'random';
await act(async () => {
render(<AnchorLink {...props} />, { useRedux: true });
});
expect(callback).toHaveBeenCalledTimes(1);
});

it('should render anchor link without short link button', () => {
const { container, queryByRole } = render(
<AnchorLink showShortLinkButton={false} {...props} />,
{ useRedux: true },
);
expect(container.querySelector(`#${props.id}`)).toBeInTheDocument();
expect(queryByRole('button')).toBe(null);
});

it('should render short link button', () => {
const { getByRole } = render(
<AnchorLink {...props} showShortLinkButton />,
{ useRedux: true },
);
expect(getByRole('button')).toBeInTheDocument();
});
});
Loading

0 comments on commit 54bfd83

Please sign in to comment.