Skip to content

Commit

Permalink
fix: add explore control tabOverride at the section level (#9495)
Browse files Browse the repository at this point in the history
  • Loading branch information
ktmud authored Apr 9, 2020
1 parent 36cd541 commit 5565895
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,10 @@ class ControlPanelsContainer extends React.Component {
const querySectionsToRender = [];
const displaySectionsToRender = [];
allSectionsToRender.forEach(section => {
// if at least one control in the secion is not `renderTrigger`
// or asks to be displayed at the Data tab
if (
section.tabOverride === 'data' ||
section.controlSetRows.some(rows =>
rows.some(
control =>
Expand Down
1 change: 1 addition & 0 deletions superset-frontend/src/explore/controlPanels/BigNumber.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ export default {
},
{
label: t('Options'),
tabOverride: 'data',
expanded: true,
controlSetRows: [
[
Expand Down

0 comments on commit 5565895

Please sign in to comment.