Update http error code from 400 to 403 (#13061)

apache · Feb 13, 2021 · 56fca17 · 56fca17
1 parent dae1258
commit 56fca17
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/superset/views/core.py b/superset/views/core.py
@@ -766,13 +766,13 @@ def explore(  # pylint: disable=too-many-locals,too-many-return-statements
         if action == "overwrite" and not slice_overwrite_perm:
             return json_error_response(
                 _("You don't have the rights to ") + _("alter this ") + _("chart"),
-                status=400,
+                status=403,
             )
 
         if action == "saveas" and not slice_add_perm:
             return json_error_response(
                 _("You don't have the rights to ") + _("create a ") + _("chart"),
-                status=400,
+                status=403,
             )
 
         if action in ("saveas", "overwrite") and datasource:
@@ -928,7 +928,7 @@ def save_or_overwrite_slice(
                     _("You don't have the rights to ")
                     + _("alter this ")
                     + _("dashboard"),
-                    status=400,
+                    status=403,
                 )
 
             flash(
@@ -946,7 +946,7 @@ def save_or_overwrite_slice(
                     _("You don't have the rights to ")
                     + _("create a ")
                     + _("dashboard"),
-                    status=400,
+                    status=403,
                 )
 
             dash = Dashboard(