Merge branch 'master' of https://github.com/preset-io/superset into h…

…ack-datasetmodal-update

.pylintrc

@@ -303,7 +303,7 @@ ignored-modules=numpy,pandas,alembic.op,sqlalchemy,alembic.context,flask_appbuil
 # List of class names for which member attributes should not be checked (useful
 # for classes with dynamically set attributes). This supports the use of
 # qualified names.
-ignored-classes=contextlib.closing,optparse.Values,thread._local,_thread._local,sqlalchemy.orm.scoping.scoped_session
+ignored-classes=contextlib.closing,optparse.Values,thread._local,_thread._local
 
 # List of members which are set dynamically and missed by pylint inference
 # system, and so shouldn't trigger E1101 when accessed. Python regular

RESOURCES/INTHEWILD.md

@@ -124,6 +124,7 @@ Join our growing community!
 - [The GRAPH Network](https://thegraphnetwork.org/)[@fccoelho]
 - [Udemy](https://www.udemy.com/) [@sungjuly]
 - [VIPKID](https://www.vipkid.com.cn/) [@illpanda]
+- [WikiMedia Foundation](https://wikimediafoundation.org) [@vg]
 
 ### Energy
 - [Airboxlab](https://foobot.io) [@antoine-galataud]

UPDATING.md

@@ -27,7 +27,7 @@ assists people when migrating to a new version.
 - [19046](https://github.com/apache/superset/pull/19046): Enables the drag and drop interface in Explore control panel by default. Flips `ENABLE_EXPLORE_DRAG_AND_DROP` and `ENABLE_DND_WITH_CLICK_UX` feature flags to `True`.
 - [18936](https://github.com/apache/superset/pull/18936): Removes legacy SIP-15 interim logic/flags—specifically the `SIP_15_ENABLED`, `SIP_15_GRACE_PERIOD_END`, `SIP_15_DEFAULT_TIME_RANGE_ENDPOINTS`, and `SIP_15_TOAST_MESSAGE` flags. Time range endpoints are no longer configurable and strictly adhere to the `[start, end)` paradigm, i.e., inclusive of the start and exclusive of the end. Additionally this change removes the now obsolete `time_range_endpoints` from the form-data and resulting in the cache being busted.
 - [19570](https://github.com/apache/superset/pull/19570): makes [sqloxide](https://pypi.org/project/sqloxide/) optional so the SIP-68 migration can be run on aarch64. If the migration is taking too long installing sqloxide manually should improve the performance.
-- [20170](https://github.com/apache/superset/pull/20170): Introduced a new endpoint for getting datasets samples.
+- [20606](https://github.com/apache/superset/pull/20606): When user clicks on chart title or "Edit chart" button in Dashboard page, Explore opens in the same tab. Clicking while holding cmd/ctrl opens Explore in a new tab. To bring back the old behaviour (always opening Explore in a new tab), flip feature flag `DASHBOARD_EDIT_CHART_IN_NEW_TAB` to `True`.
 
 ### Breaking Changes
 

docs/docs/creating-charts-dashboards/creating-your-first-dashboard.mdx

@@ -183,7 +183,7 @@ Access to dashboards is managed via owners (users that have edit permissions to
 Non-owner users access can be managed two different ways:
 
 1. Dataset permissions - if you add to the relevant role permissions to datasets it automatically grants implicit access to all dashboards that uses those permitted datasets
-2. Dashboard roles - if you enable **DASHBOARD_RBAC** feature flag  then you be able to manage which roles can access the dashboard
+2. Dashboard roles - if you enable **DASHBOARD_RBAC** [feature flag](https://superset.apache.org/docs/installation/configuring-superset#feature-flags) then you be able to manage which roles can access the dashboard
 - Having dashboard access implicitly grants read access to the associated datasets, therefore
 all charts will load their data even if feature flag is turned on and no roles assigned
 to roles the access will fallback to **Dataset permissions**

docs/docs/installation/alerts-reports.mdx

@@ -22,7 +22,7 @@ Alerts and reports are disabled by default. To turn them on, you need to do some
 
 ##### In your `superset_config.py`
 
-- `"ALERT_REPORTS"` feature flag must be turned to True.
+- `"ALERT_REPORTS"` [feature flag](https://superset.apache.org/docs/installation/configuring-superset#feature-flags) must be turned to True.
 - `CELERYBEAT_SCHEDULE` in CeleryConfig must contain schedule for `reports.scheduler`.
 - At least one of those must be configured, depending on what you want to use:
   - emails: `SMTP_*` settings

docs/docs/installation/cache.mdx

@@ -44,7 +44,7 @@ defined in `DATA_CACHE_CONFIG`.
 
 ### Caching Thumbnails
 
-This is an optional feature that can be turned on by activating it’s feature flag on config:
+This is an optional feature that can be turned on by activating it’s [feature flag](https://superset.apache.org/docs/installation/configuring-superset#feature-flags) on config:
 
 ```
 FEATURE_FLAGS = {

docs/docs/installation/configuring-superset.mdx

@@ -149,7 +149,11 @@ Make sure the pip package [`Authlib`](https://authlib.org/) is installed on the
 First, configure authorization in Superset `superset_config.py`.
 
 ```python
+from flask_appbuilder.security.manager import AUTH_OAUTH
+
+# Set the authentication type to OAuth
 AUTH_TYPE = AUTH_OAUTH
+
 OAUTH_PROVIDERS = [
     {   'name':'egaSSO',
         'token_key':'access_token', # Name of the token in the response of access_token_url

docs/docs/installation/running-on-kubernetes.mdx

@@ -239,7 +239,7 @@ configOverrides:
     # This will make sure the redirect_uri is properly computed, even with SSL offloading
     ENABLE_PROXY_FIX = True
 
-    from flask_appbuilder.security.manager import (AUTH_OAUTH, AUTH_DB)
+    from flask_appbuilder.security.manager import AUTH_OAUTH
     AUTH_TYPE = AUTH_OAUTH
     OAUTH_PROVIDERS = [
         {

docs/docs/installation/sql-templating.mdx

@@ -10,7 +10,7 @@ version: 1
 ### Jinja Templates
 
 SQL Lab and Explore supports [Jinja templating](https://jinja.palletsprojects.com/en/2.11.x/) in queries.
-To enable templating, the `ENABLE_TEMPLATE_PROCESSING` feature flag needs to be enabled in
+To enable templating, the `ENABLE_TEMPLATE_PROCESSING` [feature flag](https://superset.apache.org/docs/installation/configuring-superset#feature-flags) needs to be enabled in
 `superset_config.py`. When templating is enabled, python code can be embedded in virtual datasets and
 in Custom SQL in the filter and metric controls in Explore. By default, the following variables are
 made available in the Jinja context:

docs/yarn.lock

@@ -7834,9 +7834,9 @@ mkdirp@^0.5.5, mkdirp@~0.5.1:
     minimist "^1.2.5"
 
 moment@^2.24.0, moment@^2.25.3:
-  version "2.29.2"
-  resolved "https://registry.yarnpkg.com/moment/-/moment-2.29.2.tgz#00910c60b20843bcba52d37d58c628b47b1f20e4"
-  integrity sha512-UgzG4rvxYpN15jgCmVJwac49h9ly9NurikMWGPdVxm8GZD6XjkKPxDTjQQ43gtGgnV3X0cAyWDdP2Wexoquifg==
+  version "2.29.4"
+  resolved "https://registry.yarnpkg.com/moment/-/moment-2.29.4.tgz#3dbe052889fe7c1b2ed966fcb3a77328964ef108"
+  integrity sha512-5LC9SOxjSc2HF6vO2CyuTDNivEdoz2IvyJJGj6X8DJ0eFyfszE0QiEd+iXmBvUP3WHxSjFH/vIsA0EN00cgr8w==
 
 ms@2.0.0:
   version "2.0.0"

helm/superset/Chart.yaml

@@ -22,7 +22,7 @@ maintainers:
   - name: craig-rueda
     email: craig@craigrueda.com
     url: https://github.com/craig-rueda
-version: 0.6.4
+version: 0.6.5
 dependencies:
 - name: postgresql
   version: 11.1.22

helm/superset/templates/deployment-beat.yaml

@@ -64,8 +64,8 @@ spec:
       {{- end }}
       securityContext:
         runAsUser: {{ .Values.runAsUser }}
-      {{- if .Values.supersetCeleryBeat.securityContext }}
-        {{ toYaml .Values.supersetCeleryBeat.securityContext | nindent 8 }}
+      {{- if .Values.supersetCeleryBeat.podSecurityContext }}
+        {{ toYaml .Values.supersetCeleryBeat.podSecurityContext | nindent 8 }}
       {{- end }}
       {{- if .Values.supersetCeleryBeat.initContainers }}
       initContainers:
@@ -78,6 +78,9 @@ spec:
         - name: {{ .Chart.Name }}
           image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"
           imagePullPolicy: {{ .Values.image.pullPolicy }}
+          {{- if .Values.supersetCeleryBeat.containerSecurityContext }}
+          securityContext: {{ toYaml .Values.supersetCeleryBeat.containerSecurityContext | nindent 12 }}
+          {{- end }}
           command: {{  tpl (toJson .Values.supersetCeleryBeat.command) . }}
           env:
             - name: "SUPERSET_PORT"

helm/superset/templates/deployment-worker.yaml

@@ -62,8 +62,8 @@ spec:
       {{- end }}
       securityContext:
         runAsUser: {{ .Values.runAsUser }}
-      {{- if .Values.supersetWorker.securityContext }}
-        {{ toYaml .Values.supersetWorker.securityContext | nindent 8 }}
+      {{- if .Values.supersetWorker.podSecurityContext }}
+        {{ toYaml .Values.supersetWorker.podSecurityContext | nindent 8 }}
       {{- end }}
       {{- if .Values.supersetWorker.initContainers }}
       initContainers:
@@ -76,6 +76,9 @@ spec:
         - name: {{ .Chart.Name }}
           image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"
           imagePullPolicy: {{ .Values.image.pullPolicy }}
+          {{- if .Values.supersetWorker.containerSecurityContext }}
+          securityContext: {{ toYaml .Values.supersetWorker.containerSecurityContext | nindent 12 }}
+          {{- end }}
           command: {{  tpl (toJson .Values.supersetWorker.command) . }}
           env:
             - name: "SUPERSET_PORT"

helm/superset/templates/deployment.yaml

@@ -65,8 +65,8 @@ spec:
       {{- end }}
       securityContext:
         runAsUser: {{ .Values.runAsUser }}
-      {{- if .Values.supersetNode.securityContext }}
-        {{ toYaml .Values.supersetNode.securityContext | nindent 8 }}
+      {{- if .Values.supersetNode.podSecurityContext }}
+        {{ toYaml .Values.supersetNode.podSecurityContext | nindent 8 }}
       {{- end }}
       {{- if .Values.supersetNode.initContainers }}
       initContainers:
@@ -79,6 +79,9 @@ spec:
         - name: {{ .Chart.Name }}
           image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"
           imagePullPolicy: {{ .Values.image.pullPolicy }}
+          {{- if .Values.supersetNode.containerSecurityContext }}
+          securityContext: {{ toYaml .Values.supersetNode.containerSecurityContext | nindent 12 }}
+          {{- end }}
           command: {{  tpl (toJson .Values.supersetNode.command) . }}
           env:
             - name: "SUPERSET_PORT"

helm/superset/templates/init-job.yaml

@@ -36,8 +36,8 @@ spec:
       {{- end }}
       securityContext:
         runAsUser: {{ .Values.runAsUser }}
-      {{- if .Values.init.securityContext }}
-        {{ toYaml .Values.init.securityContext | nindent 8 }}
+      {{- if .Values.init.podSecurityContext }}
+        {{ toYaml .Values.init.podSecurityContext | nindent 8 }}
       {{- end }}
       {{- if .Values.init.initContainers }}
       initContainers:
@@ -64,6 +64,9 @@ spec:
               name: {{ tpl . $ }}
           {{- end }}
         imagePullPolicy: {{ .Values.image.pullPolicy }}
+        {{- if .Values.init.containerSecurityContext }}
+        securityContext: {{ toYaml .Values.init.containerSecurityContext | nindent 12 }}
+        {{- end }}
         volumeMounts:
           - name: superset-config
             mountPath: {{ .Values.configMountPath | quote }}

helm/superset/values.schema.json

@@ -279,7 +279,10 @@
                 "resources": {
                     "type": "object"
                 },
-                "securityContext": {
+                "podSecurityContext": {
+                    "type": "object"
+                },
+                "containerSecurityContext": {
                     "type": "object"
                 }
             },
@@ -315,7 +318,10 @@
                 "resources": {
                     "type": "object"
                 },
-                "securityContext": {
+                "podSecurityContext": {
+                    "type": "object"
+                },
+                "containerSecurityContext": {
                     "type": "object"
                 }
             },
@@ -352,7 +358,10 @@
                 "resources": {
                     "type": "object"
                 },
-                "securityContext": {
+                "podSecurityContext": {
+                    "type": "object"
+                },
+                "containerSecurityContext": {
                     "type": "object"
                 }
             },
@@ -418,7 +427,10 @@
                 "podAnnotations": {
                     "$ref": "https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v1.23.0/_definitions.json##/definitions/io.k8s.apimachinery.pkg.apis.meta.v1.ObjectMeta/properties/annotations"
                 },
-                "securityContext": {
+                "podSecurityContext": {
+                    "type": "object"
+                },
+                "containerSecurityContext": {
                     "type": "object"
                 }
             },

helm/superset/values.yaml

@@ -263,7 +263,8 @@ supersetNode:
     # requests:
     #  cpu: 100m
     #  memory: 128Mi
-  securityContext: {}
+  podSecurityContext: {}
+  containerSecurityContext: {}
 ##
 ## Superset worker configuration
 supersetWorker:
@@ -294,7 +295,8 @@ supersetWorker:
     # requests:
     #  cpu: 100m
     #  memory: 128Mi
-  securityContext: {}
+  podSecurityContext: {}
+  containerSecurityContext: {}
 ##
 ## Superset beat configuration (to trigger scheduled jobs like reports)
 supersetCeleryBeat:
@@ -327,7 +329,8 @@ supersetCeleryBeat:
     # requests:
     #  cpu: 100m
     #  memory: 128Mi
-  securityContext: {}
+  podSecurityContext: {}
+  containerSecurityContext: {}
 ##
 ## Init job configuration
 init:
@@ -391,7 +394,8 @@ init:
     fi
   ## Annotations to be added to init job pods
   podAnnotations: {}
-  securityContext: {}
+  podSecurityContext: {}
+  containerSecurityContext: {}
 ##
 ## Configuration values for the postgresql dependency.
 ## ref: https://github.com/kubernetes/charts/blob/master/stable/postgresql/README.md