Skip to content

Commit

Permalink
refactor: Removes the CSS files from the Sankey Loop plugin (#19494)
Browse files Browse the repository at this point in the history
* refactor: Removes the CSS files from the Sankey Loop plugin

* Gets opacity from the theme
  • Loading branch information
michael-s-molina authored Apr 6, 2022
1 parent 2d81c4c commit 6fa99d6
Show file tree
Hide file tree
Showing 5 changed files with 89 additions and 100 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,38 +2,36 @@
"name": "@superset-ui/legacy-plugin-chart-sankey-loop",
"version": "0.18.25",
"description": "Superset Legacy Chart - Sankey Diagram with Loops",
"sideEffects": [
"*.css"
],
"main": "lib/index.js",
"module": "esm/index.js",
"files": [
"esm",
"lib"
],
"repository": {
"type": "git",
"url": "git+https://github.com/apache-superset/superset-ui.git"
},
"keywords": [
"superset"
],
"author": "Superset",
"license": "Apache-2.0",
"homepage": "https://github.com/apache-superset/superset-ui#readme",
"bugs": {
"url": "https://github.com/apache-superset/superset-ui/issues"
},
"homepage": "https://github.com/apache-superset/superset-ui#readme",
"publishConfig": {
"access": "public"
"repository": {
"type": "git",
"url": "git+https://github.com/apache-superset/superset-ui.git"
},
"license": "Apache-2.0",
"author": "Superset",
"main": "lib/index.js",
"module": "esm/index.js",
"files": [
"esm",
"lib"
],
"dependencies": {
"d3-sankey-diagram": "^0.7.3",
"d3-selection": "^1.4.0",
"prop-types": "^15.6.2"
},
"peerDependencies": {
"@superset-ui/chart-controls": "*",
"@superset-ui/core": "*"
"@superset-ui/core": "*",
"react": "^16.13.1"
},
"publishConfig": {
"access": "public"
}
}

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import React from 'react';
import { reactify, styled } from '@superset-ui/core';
import Component from './SankeyLoop';

const ReactComponent = reactify(Component);

const Sankey = ({ className, ...otherProps }) => (
<div className={className}>
<ReactComponent {...otherProps} />
</div>
);

export default styled(Sankey)`
${({ theme }) => `
.superset-legacy-chart-sankey-loop .node rect {
cursor: move;
fill-opacity: ${theme.opacity.heavy};
shape-rendering: crispEdges;
}
.superset-legacy-chart-sankey-loop .node text {
pointer-events: none;
text-shadow: 0 1px 0 ${theme.colors.grayscale.light5};
}
.superset-legacy-chart-sankey-loop .link {
fill: none;
stroke: ${theme.colors.grayscale.dark2};
stroke-opacity: ${theme.opacity.light};
}
.superset-legacy-chart-sankey-loop .link:hover {
stroke-opacity: ${theme.opacity.mediumHeavy};
}
.superset-legacy-chart-sankey-loop .link path {
opacity: ${theme.opacity.mediumLight};
stroke-opacity: 0;
}
.superset-legacy-chart-sankey-loop .link:hover path {
opacity: ${theme.opacity.heavy};
}
.superset-legacy-chart-sankey-loop .link text {
fill: ${theme.colors.grayscale.base};
font-size: ${theme.gridUnit * 3}px;
}
.superset-legacy-chart-sankey-loop .link:hover text {
opacity: 1;
}
`}
`;

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ import {
CategoricalColorNamespace,
} from '@superset-ui/core';

import './SankeyLoop.css';

// a problem with 'd3-sankey-diagram' is that the sankey().extent() paramters, which
// informs the layout of the bounding box of the sankey columns, does not account
// for labels and paths which happen to be layedout outside that rectangle.
Expand Down

0 comments on commit 6fa99d6

Please sign in to comment.