Skip to content

Commit

Permalink
Fix docker configurations and docker installation guide. (#7827)
Browse files Browse the repository at this point in the history
* Add Auto option to point radius to make it work as expected since the example using this didn't work because of this (and also as the tooltip says the auto option should be available)

* Remove trailing space

* Fix docker configurations and docker installation guide.
- Fix installation guide regarding passing enviromental variable to docker-compose.
- Add gevent installation command in Dockerfile. (Didn't add it in requirements because it's not really a requirement for the whole project)
- Add user: root:root to allow superset service to work in development mode. Since access to binded superset directory to local requires root user.
- Also add localhost to postgres and redis services to reduce unintended security risk.

* Fix docker configurations and docker installation guide.
- Fix installation guide regarding passing enviromental variable to docker-compose.
- Add gevent installation command in Dockerfile. (Didn't add it in requirements because it's not really a requirement for the whole project)
- Add user: root:root to allow superset service to work in development mode. Since access to binded superset directory to local requires root user.
- Also add localhost to postgres and redis services to reduce unintended security risk.
  • Loading branch information
ali-bahjati authored and mistercrunch committed Jul 16, 2019
1 parent 9b8bfbb commit a36c136
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
2 changes: 2 additions & 0 deletions contrib/docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ RUN pip install --upgrade setuptools pip \
&& pip install -r requirements.txt -r requirements-dev.txt \
&& rm -rf /root/.cache/pip

RUN pip install gevent

COPY --chown=superset:superset superset superset

ENV PATH=/home/superset/superset/bin:$PATH \
Expand Down
2 changes: 1 addition & 1 deletion contrib/docker/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Docker is an easy way to get stated with Superset.
To initialize the database with a user and example charts, dashboards and datasets run:

```bash
SUPERSET_LOAD_EXAMPLES=yes docker-compose run --rm superset ./docker-init.sh
docker-compose run -e SUPERSET_LOAD_EXAMPLES=yes --rm superset ./docker-init.sh
```

This may take a minute.
Expand Down
5 changes: 3 additions & 2 deletions contrib/docker/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ services:
image: redis:3.2
restart: unless-stopped
ports:
- 6379:6379
- "127.0.0.1:6379:6379"
volumes:
- redis:/data

Expand All @@ -32,7 +32,7 @@ services:
POSTGRES_PASSWORD: superset
POSTGRES_USER: superset
ports:
- 5432:5432
- "127.0.0.1:5432:5432"
volumes:
- postgres:/var/lib/postgresql/data

Expand All @@ -52,6 +52,7 @@ services:
# If using production, comment development volume below
#SUPERSET_ENV: production
SUPERSET_ENV: development
user: root:root
ports:
- 8088:8088
depends_on:
Expand Down

0 comments on commit a36c136

Please sign in to comment.