add test

apache · Jul 7, 2023 · a5a8780 · a5a8780
1 parent e8eaae7
commit a5a8780
Showing 1 changed file with 28 additions and 1 deletion.
diff --git a/superset-frontend/packages/superset-ui-core/test/currency-format/utils.test.ts b/superset-frontend/packages/superset-ui-core/test/currency-format/utils.test.ts
@@ -72,7 +72,7 @@ it('buildCustomFormatters with saved metrics returns custom formatters object',
       {
         sum__num: { symbol: 'USD', symbolPosition: 'prefix' },
       },
-      {},
+      { sum__num: ',.2' },
       ',.1f',
     );
 
@@ -83,6 +83,33 @@ it('buildCustomFormatters with saved metrics returns custom formatters object',
 
   expect(customFormatters.sum__num).toBeInstanceOf(CurrencyFormatter);
   expect(customFormatters.count).toBeInstanceOf(NumberFormatter);
+  expect((customFormatters.sum__num as CurrencyFormatter).d3Format).toEqual(
+    ',.1f',
+  );
+});
+
+it('buildCustomFormatters uses dataset d3 format if not provided in control panel', () => {
+  const customFormatters: Record<string, ValueFormatter> =
+    buildCustomFormatters(
+      [
+        {
+          expressionType: 'SIMPLE',
+          aggregate: 'COUNT',
+          column: { column_name: 'test' },
+        },
+        'sum__num',
+        'count',
+      ],
+      {
+        sum__num: { symbol: 'USD', symbolPosition: 'prefix' },
+      },
+      { sum__num: ',.2' },
+      undefined,
+    );
+
+  expect((customFormatters.sum__num as CurrencyFormatter).d3Format).toEqual(
+    ',.2',
+  );
 });
 
 it('getCustomFormatter', () => {