address comments

apache · Feb 22, 2023 · a60846c · a60846c
1 parent f47e3a8
commit a60846c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/superset-frontend/src/visualizations/TimeTable/SparklineCell.tsx b/superset-frontend/src/visualizations/TimeTable/SparklineCell.tsx
@@ -37,13 +37,14 @@ import {
 } from '@visx/xychart';
 
 interface Props {
+  ariaLabel: string;
   dataKey: string;
   className?: string;
   data: Array<number>;
   entries: Array<any>;
   height: number;
-  numberFormat?: string;
-  dateFormat?: string;
+  numberFormat: string;
+  dateFormat: string;
   renderTooltip: ({ index }: { index: number }) => React.ReactNode;
   showYAxis: boolean;
   width: number;
@@ -80,6 +81,7 @@ function isValidBoundValue(value?: number | string) {
 }
 
 const SparklineCell = ({
+  ariaLabel,
   dataKey,
   data,
   width = 300,
@@ -160,6 +162,7 @@ const SparklineCell = ({
   return (
     <>
       <XYChart
+        accessibilityLabel={ariaLabel}
         width={width}
         height={height}
         margin={margin}

diff --git a/superset-frontend/src/visualizations/TimeTable/TimeTable.jsx b/superset-frontend/src/visualizations/TimeTable/TimeTable.jsx
@@ -162,6 +162,7 @@ const TimeTable = ({
 
       return (
         <SparklineCell
+          ariaLabel={`spark-${valueField}`}
           width={parseInt(column.width, 10) || 300}
           height={parseInt(column.height, 10) || 50}
           data={sparkData}