fix(colors): fix color schemes (#13945)

* fix: fix color schemes * fix: tests case
apache · Apr 4, 2021 · e062906 · e062906
1 parent abd4051
commit e062906
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/superset-frontend/spec/javascripts/dashboard/components/PropertiesModal_spec.jsx b/superset-frontend/spec/javascripts/dashboard/components/PropertiesModal_spec.jsx
@@ -113,7 +113,7 @@ describe('PropertiesModal', () => {
             const spy = jest.spyOn(modalInstance, 'onMetadataChange');
             modalInstance.onColorSchemeChange('SUPERSET_DEFAULT');
             expect(spy).toHaveBeenCalledWith(
-              '{"color_scheme": "SUPERSET_DEFAULT"}',
+              '{"color_scheme": "SUPERSET_DEFAULT", "label_colors": {}}',
             );
           });
         });

diff --git a/superset-frontend/src/dashboard/components/PropertiesModal.jsx b/superset-frontend/src/dashboard/components/PropertiesModal.jsx
@@ -28,6 +28,7 @@ import {
   t,
   SupersetClient,
   getCategoricalSchemeRegistry,
+  CategoricalColorNamespace,
 } from '@superset-ui/core';
 
 import Modal from 'src/common/components/Modal';
@@ -158,6 +159,15 @@ class PropertiesModal extends React.PureComponent {
       Object.keys(jsonMetadataObj).includes('color_scheme')
     ) {
       jsonMetadataObj.color_scheme = value;
+      jsonMetadataObj.label_colors = Object.keys(
+        jsonMetadataObj.label_colors ?? {},
+      ).reduce(
+        (prev, next) => ({
+          ...prev,
+          [next]: CategoricalColorNamespace.getScale(value)(next),
+        }),
+        {},
+      );
       this.onMetadataChange(jsonStringify(jsonMetadataObj));
     }