database modal should close on connect with tab layout (#14771)

apache · May 24, 2021 · fbe6f16 · fbe6f16
1 parent e9657af
commit fbe6f16
Show file tree

Hide file tree

Showing 3 changed files with 240 additions and 247 deletions.
diff --git a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/SqlAlchemyForm.tsx b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/SqlAlchemyForm.tsx
@@ -44,6 +44,7 @@ const SqlAlchemyTab = ({
         <input
           type="text"
           name="database_name"
+          data-test="database-name-input"
           value={db?.database_name || ''}
           placeholder={t('Name your database')}
           onChange={onInputChange}
@@ -62,6 +63,7 @@ const SqlAlchemyTab = ({
         <input
           type="text"
           name="sqlalchemy_uri"
+          data-test="sqlalchemy-uri-input"
           value={db?.sqlalchemy_uri || ''}
           autoComplete="off"
           placeholder={t(