Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard] Chart dropdown list should overflow #12281

Closed
3 tasks done
graceguo-supercat opened this issue Jan 5, 2021 · 4 comments
Closed
3 tasks done

[Dashboard] Chart dropdown list should overflow #12281

graceguo-supercat opened this issue Jan 5, 2021 · 4 comments
Labels
#bug:regression Bugs that are identified as regessions P1 Priority item - Major

Comments

@graceguo-supercat
Copy link

Before

Screen Shot 2021-01-05 at 9 24 07 AM

Current

Screen Shot 2021-01-05 at 9 31 44 AM

How to reproduce the bug

  1. Open dashboard, with a few charts in a row
  2. Click on dropdown icon on each chart title

Environment

latest master

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Note, this regression was introduced a couple of month ago.

@junlincc @zuzana-vej
@graceguo-supercat graceguo-supercat added P1 Priority item - Major viz:dashboard:ui labels Jan 5, 2021
@zuzana-vej
Copy link
Contributor

Related to this issue: #12004

@zuzana-vej zuzana-vej added the #bug:regression Bugs that are identified as regessions label Jan 5, 2021
@junlincc
Copy link
Member

junlincc commented Jan 5, 2021 •
edited
Loading

#12153 this open PR should fix issue
we tested, spotted some other issues in Dashboard but not related. do you feel comfortable merging this PR and see if that solve the problem?
@graceguo-supercat

@junlincc junlincc added rush! Requires immediate attention assigned:flexiana labels Jan 5, 2021
@maloun96
Copy link
Contributor

maloun96 commented Jan 6, 2021 •
edited
Loading

Tested with the latest code from master.
Kapture 2021-01-06 at 14 44 55

@junlincc
Copy link
Member

junlincc commented Jan 8, 2021 •
edited
Loading

confirmed, this issue has been fixed on master by @maloun96 #12169
Screen Shot 2021-01-07 at 6 32 28 PM
Screen Shot 2021-01-07 at 6 31 43 PM
Screen Shot 2021-01-07 at 6 31 20 PM

@junlincc junlincc closed this as completed Jan 8, 2021
@junlincc junlincc removed the rush! Requires immediate attention label Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
#bug:regression Bugs that are identified as regessions P1 Priority item - Major
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@maloun96 @graceguo-supercat @zuzana-vej @junlincc