Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cosmetic][dashboard] Filter dropdown options on time grain filter not visible #12004

Closed
2 of 3 tasks
zuzana-vej opened this issue Dec 10, 2020 · 5 comments
Closed
2 of 3 tasks
Labels
#bug:regression Bugs that are identified as regessions !deprecated-label:bug Deprecated label - Use #bug instead

Comments

@zuzana-vej
Copy link
Contributor

zuzana-vej commented Dec 10, 2020

Filter dropdown options are not visible, making it hard for user to make their filter selection.

Expected results

The filter dropdown should display in a way that it's possible for user to scroll through the options. Drop down should display at least 4 or 5 options, if not all, and give enough space to scroll down and see options easily.

Actual results

The filter dropdown displays improperly making very hard for user to select their filter, specifically Drop down for filters box does not allow to see more than 1.5 options, which makes it very hard to use

Screenshots

Screen Shot 2020-12-10 at 11 43 06 AM

filter-invisible

How to reproduce the bug

  1. Go to Dashboard
  2. Click on Filter box (this is specifically a time grain filter. From Dashboard layout perspective, this time grain filter is right above "Apply button" on filter box. Right below the filter box is "header" followed by charts.
  3. When clicking to selecting time grain, See error it doesn't display properly

Environment

(please complete the following information):

  • superset version: master

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

This was working fine last week, so likely is a regression.

@zuzana-vej zuzana-vej added the !deprecated-label:bug Deprecated label - Use #bug instead label Dec 10, 2020
@zuzana-vej zuzana-vej added the #bug:cosmetic Cosmetic/layout/design tweak needed label Dec 10, 2020
@junlincc
Copy link
Member

junlincc commented Dec 10, 2020

@adam-stasiak let's add this to our test case.

@zuzana-vej thanks for reporting!
im not able to reproduce from latest master, can you attach a gif?

ezgif-7-f947b0ecf731

@junlincc junlincc added the #bug:cant-reproduce Bugs that cannot be reproduced label Dec 10, 2020
@junlincc junlincc removed their assignment Dec 10, 2020
@junlincc
Copy link
Member

@zuzana-vej btw, we recently fixed the filter box, it's scrollable when the size is small. have you tried it?

@zuzana-vej
Copy link
Contributor Author

zuzana-vej commented Dec 15, 2020

Here is a recording. I would expect the TIME GRAIN box behave same as the other dropdowns - see the difference on the video.

filterbox-issue

Otherwise this happens when user resizes the filter box to a small size. The larger the size, the more dropdown option they see - specifically for TIME GRAIN. If the filter box has only TIME GRAIN and they resize it, they face the issue initially described. If the filter box has 10 other filters, or if they keep it large (height) they might not face this issue at all. Most users try to conserve space and make filter boxes as small as possible.
As you see on the video, this issue doesn't occur for other filter dropdowns - like here it doesn't happen for "office" dropdown. It would be great if the drop downs behave in a same way (otherwise user might think it's a bug).

@zuzana-vej
Copy link
Contributor Author

zuzana-vej commented Dec 18, 2020

Just wanted to confirm this is still the issue and we are 100% up to date with mater now -- see the gif in above listed comment. it only happens for time grain, and when you don't have many other filter boxes below.
(@junlincc can someone working on filters from your side check? it's a low priority, since it's just a cosmetic issue, but we are able to reproduce it pretty consistently)

@zuzana-vej zuzana-vej changed the title Cosmetic: Filter dropdown options on time grain filter not visible [cosmetic][dashboard] Filter dropdown options on time grain filter not visible Dec 18, 2020
@junlincc junlincc added assigned:flexiana and removed #bug:cant-reproduce Bugs that cannot be reproduced #bug:cosmetic Cosmetic/layout/design tweak needed labels Jan 2, 2021
@zuzana-vej zuzana-vej added viz:dashboard:ui #bug:regression Bugs that are identified as regessions labels Jan 5, 2021
rusackas pushed a commit that referenced this issue Jan 6, 2021
* Fix hidden dropdown when overflowing

* Remove unnecessary space

* Remove unused var
@zuzana-vej
Copy link
Contributor Author

Tested - this looks resolved now on Dashboard (where we discovered the bug).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug:regression Bugs that are identified as regessions !deprecated-label:bug Deprecated label - Use #bug instead
Projects
None yet
Development

No branches or pull requests

2 participants