Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duckdb - unable to list the table schema #21210

Closed
forestlzj opened this issue Aug 26, 2022 · 4 comments · Fixed by #21495
Closed

duckdb - unable to list the table schema #21210

forestlzj opened this issue Aug 26, 2022 · 4 comments · Fixed by #21495
Labels
#bug Bug report

Comments

@forestlzj
Copy link
Contributor

A clear and concise description of what the bug is.

After setting duckb connection to a local file, in "SQL Editor", it can show list of duckdb connecton and schema correctly, when select a duckdb schema, it can't show the table names in the "See Table schema" drop down box. In superset oupt log, it shows error:

Engine no attribute 'exec_driver_sql'

Environment

(please complete the following information):

  • browser type and version: chrome 104.0.5112.102
  • superset version: 2.0
  • python version: 3.9.13
  • duckdb version: 0.4.0
  • duckdb-engine version: 0.6.2
  • any feature flags active:

Checklist

Add any other context about the problem here.
OS: Redhat 7.9

@forestlzj forestlzj added the #bug Bug report label Aug 26, 2022
@forestlzj
Copy link
Contributor Author

supplement: It can execute sql on duckb correctly but can't show table list and table schema

@forestlzj
Copy link
Contributor Author

I think it can be fixed after this merge: Mause/duckdb_engine#393

@Mause
Copy link

Mause commented Sep 8, 2022

@forestlzj are you able to try with the latest duckdb-engine version? (0.6.3)

@forestlzj
Copy link
Contributor Author

@Mause duckdb-engine version (0.6.3, 0.6.4) works now, but it still needs to make some minor code change in duckdb_engine specs in superset to fix the said problem. I will submit a PR in superset .

forestlzj added a commit to forestlzj/superset that referenced this issue Sep 16, 2022
 fix bug: apache#21210
the previous approach inspector.get_table_names() always gets table name in default "main" schema instead of getting table name from an input schema specified in superset UI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants