More Label touchups (margins) #10722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10722 +/- ##
==========================================
- Coverage 65.00% 59.56% -5.44%
==========================================
Files 789 360 -429
Lines 37128 23224 -13904
Branches 3555 0 -3555
==========================================
- Hits 24134 13834 -10300
+ Misses 12887 9390 -3497
+ Partials 107 0 -107
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
rusackas
commented
Aug 29, 2020
mistercrunch
approved these changes
Sep 3, 2020
amitmiran137
pushed a commit
to ofekisr/incubator-superset
that referenced
this pull request
Sep 7, 2020
…boards_permissions * upstream/master: (32 commits) docs: Add a note to contributing.md on reporting security vulnerabilities (apache#10796) Fix: Include RLS filters for cache keys (apache#10805) feat: filters for database list view (apache#10772) fix: MVC show saved query (apache#10781) added creator column and adjusted order columns (apache#10789) security: disallow uuid package on jinja2 (apache#10794) feat: CRUD REST API for saved queries (apache#10777) fix: disable domain sharding on explore view (apache#10787) fix: can not type `0.05` in `TextControl` (apache#10778) fix: pivot table timestamp grouping (apache#10774) fix: add validator information to email/slack alerts (apache#10762) More Label touchups (margins) (apache#10722) fix: dashboard extra filters (apache#10692) fix: re-installing local superset in cache image (apache#10766) feat: SIP-34 table list view for databases (apache#10705) refactor: convert DatasetList schema filter to use new distinct api (apache#10746) chore: removing fsevents dependency (apache#10751) Fix precommit hook for docs/installation.rst (apache#10759) feat(database): POST, PUT, DELETE API endpoints (apache#10741) docs: Update OAuth configuration in installation.rst (apache#10748) ...
villebro
pushed a commit
to preset-io/superset
that referenced
this pull request
Sep 11, 2020
* labels with onClick don't need .pointer. No labels need `m-r-5` * making Timer a proper Label * a little linting * addresing (helpful, thanks) comment
villebro
pushed a commit
that referenced
this pull request
Sep 11, 2020
* labels with onClick don't need .pointer. No labels need `m-r-5` * making Timer a proper Label * a little linting * addresing (helpful, thanks) comment
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* labels with onClick don't need .pointer. No labels need `m-r-5` * making Timer a proper Label * a little linting * addresing (helpful, thanks) comment
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This makes some margins intrinsic to the Label component. These margins are NOT applied on the left side of the
first-of-typeor right side oflast-of-type. This means we shouldn't need them-r-5classesin any Labels. We also don't really need thepointerclass on labels with anonClickprop, so I killed that too. One example of alast-of-type` that still DOES need margin on the right is in the screenshot below, but I added that margin to the context of the wrapping container, which is what we should probably be doing where exceptions apply to the rule.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
Storybook, in-situ viewing, CI passing.
ADDITIONAL INFORMATION