Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: moved inline inputs styles to component's less file #11427

Merged
merged 1 commit into from
Oct 27, 2020
Merged

fix: moved inline inputs styles to component's less file #11427

merged 1 commit into from
Oct 27, 2020

Conversation

kkucharc
Copy link
Contributor

@kkucharc kkucharc commented Oct 26, 2020 •
edited
Loading

SUMMARY

Time range wasn't rendering properly because of lack of styles. Styles were moved to FilterBox's css and it should render everywhere in same way.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
Screenshot 2020-10-26 at 15 53 42

After:
Screenshot 2020-10-26 at 15 50 05

TEST PLAN

ADDITIONAL INFORMATION

mistercrunch
mistercrunch approved these changes Oct 27, 2020
View reviewed changes
Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a quick fix, this whole component is on the roadmap for a bigger rehaul, much of it likely to be re-written, so this is a good band aid for now.

@mistercrunch mistercrunch merged commit 94e0f0c into apache:master Oct 27, 2020
@mistercrunch
Copy link
Member

@kkucharc protip that if you write "closes #10471" in your PR comment, GitHub will auto-close the associated issue as we merge

auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@kkucharc @auxten
Moved css of inline inputs of DateFilterControl to css of FilterBox w…
75e2b57 
…here it appears. (apache#11427)
@laxmanraparthi laxmanraparthi mentioned this pull request Jun 28, 2023
Open
This was referenced Nov 26, 2023
Open
Open
Open
@m-ajay m-ajay mentioned this pull request Nov 28, 2023
Open
This was referenced Dec 14, 2023
Open
Open
This was referenced Dec 20, 2023
Open
Open
@matrix-compute matrix-compute mentioned this pull request Dec 26, 2023
Open
@laxmanraparthi laxmanraparthi mentioned this pull request Jan 2, 2024
Open
@matrix-compute matrix-compute mentioned this pull request Feb 16, 2024
Open
@matrix-compute matrix-compute mentioned this pull request Mar 11, 2024
Merged
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
@laxmanraparthi laxmanraparthi mentioned this pull request Mar 15, 2024
Open
@matrix-compute matrix-compute mentioned this pull request Mar 23, 2024
Open
This was referenced May 14, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistercrunch mistercrunch mistercrunch approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kkucharc @mistercrunch