feat: move keyboard shortcut hints to tooltips #12100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eschutho
changed the title
eschutho
force-pushed
the
elizabeth/sqllab-keyboard-shortcuts
branch
from
e2dbaae
to
15be611
Compare
Codecov Report
@@ Coverage Diff @@
## feat-sql-toolbar #12100 +/- ##
====================================================
- Coverage 67.32% 63.51% -3.81%
====================================================
Files 963 963
Lines 47390 47381 -9
Branches 4620 4620
====================================================
- Hits 31903 30092 -1811
- Misses 15374 17104 +1730
- Partials 113 185 +72
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
betodealmeida
approved these changes
Dec 18, 2020
hughhhh
reviewed
Dec 18, 2020
| <Button {...commonBtnProps} cta onClick={stopQuery}> | ||
| <Button | ||
| {...commonBtnProps} | ||
| cta |
There was a problem hiding this comment.
what's cta here? i think we can remove it
There was a problem hiding this comment.
it looks like the cta prop makes it all caps.
hughhhh
reviewed
Dec 18, 2020
| @@ -67,7 +72,7 @@ const RunQueryActionButton = ({ | |||
| cta | |||
| onClick={() => runQuery(true)} | |||
| key="run-async-btn" | |||
| tooltip={t('Run query asynchronously (Ctrl + ↵)')} | |||
| tooltip={t('Run query (Ctrl + Return)')} | |||
There was a problem hiding this comment.
Suggested change
| tooltip={t('Run query (Ctrl + Return)')} | |
| tooltip={t('Run Query (Ctrl + Return)')} |
There was a problem hiding this comment.
The design has Query as lowercase, but let's check with Stephen!
hughhhh
approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Updated Keyboard Shortcuts Interface
Remove existing keyboard shortcuts button
Hover tooltips should show up on the following:
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TEST PLAN
Jest tests
ADDITIONAL INFORMATION