Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update CTAS/CVAS button & Cost Estimate #12131

Merged
merged 14 commits into from
Dec 21, 2020

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Dec 18, 2020

SUMMARY

Updated CTAS/CVAS and Cost Estimate buttons in SQL lab toolbar. Most moving logic into these new components

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

CTAS & CVAS:
https://www.loom.com/share/b3173c936ff1442d8dac2906e7778f85

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Dec 18, 2020

Codecov Report

Merging #12131 (27bb3e7) into feat-sql-toolbar (cf39980) will decrease coverage by 0.56%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           feat-sql-toolbar   #12131      +/-   ##
====================================================
- Coverage             64.20%   63.64%   -0.57%     
====================================================
  Files                   481      481              
  Lines                 29684    29684              
====================================================
- Hits                  19059    18891     -168     
- Misses                10625    10793     +168     
Flag Coverage Δ
python 63.64% <ø> (-0.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.72%) ⬇️
superset/db_engine_specs/hive.py 54.61% <0.00%> (-29.62%) ⬇️
superset/db_engine_specs/presto.py 69.95% <0.00%> (-12.45%) ⬇️
superset/examples/world_bank.py 97.10% <0.00%> (-2.90%) ⬇️
superset/examples/birth_names.py 96.51% <0.00%> (-2.33%) ⬇️
superset/views/database/mixins.py 80.70% <0.00%> (-1.76%) ⬇️
superset/models/core.py 88.07% <0.00%> (-0.82%) ⬇️
superset/connectors/sqla/models.py 91.37% <0.00%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf39980...7d1408d. Read the comment docs.

@hughhhh hughhhh changed the base branch from master to feat-sql-toolbar December 18, 2020 21:13
@pull-request-size pull-request-size bot added size/L and removed size/M labels Dec 18, 2020
@hughhhh hughhhh marked this pull request as ready for review December 18, 2020 22:32
Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would just suggest moving 'table' and 'view' into an enum as a small improvement.

allow_cvas: allowCVAS,
} = this.props.database;

const showMenu = allowCTAS && allowCVAS;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be or?

@hughhhh hughhhh merged commit 9a88223 into feat-sql-toolbar Dec 21, 2020
@hughhhh hughhhh deleted the hugh/ch229-forward branch December 21, 2020 21:33
eschutho pushed a commit to preset-io/superset that referenced this pull request Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants