-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update CTAS/CVAS button & Cost Estimate #12131
Conversation
Codecov Report
@@ Coverage Diff @@
## feat-sql-toolbar #12131 +/- ##
====================================================
- Coverage 64.20% 63.64% -0.57%
====================================================
Files 481 481
Lines 29684 29684
====================================================
- Hits 19059 18891 -168
- Misses 10625 10793 +168
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I would just suggest moving 'table' and 'view' into an enum as a small improvement.
allow_cvas: allowCVAS, | ||
} = this.props.database; | ||
|
||
const showMenu = allowCTAS && allowCVAS; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be or
?
SUMMARY
Updated CTAS/CVAS and Cost Estimate buttons in SQL lab toolbar. Most moving logic into these new components
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
CTAS & CVAS:
https://www.loom.com/share/b3173c936ff1442d8dac2906e7778f85
TEST PLAN
ADDITIONAL INFORMATION