Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rendering standalone chart #12179

Merged
merged 1 commit into from
Dec 23, 2020

Conversation

agatapst
Copy link
Contributor

@agatapst agatapst commented Dec 22, 2020

SUMMARY

This PR fixes problem with rendering standalone charts.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

standalone

TEST PLAN

Go to Charts and click on a chart. When it's loaded add &standalone=true to the URL and check if chart is rendered.

ADDITIONAL INFORMATION

cc @villebro

@codecov-io
Copy link

codecov-io commented Dec 22, 2020

Codecov Report

Merging #12179 (881635c) into master (942e321) will decrease coverage by 3.76%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12179      +/-   ##
==========================================
- Coverage   66.75%   62.99%   -3.77%     
==========================================
  Files         994      994              
  Lines       49068    49093      +25     
  Branches     4979     4978       -1     
==========================================
- Hits        32756    30926    -1830     
- Misses      16184    17967    +1783     
- Partials      128      200      +72     
Flag Coverage Δ
cypress ?
javascript 61.23% <0.00%> (+<0.01%) ⬆️
python 64.13% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ntend/src/explore/components/ExploreChartPanel.jsx 13.63% <0.00%> (-62.49%) ⬇️
...nd/src/explore/components/ExploreViewContainer.jsx 2.59% <ø> (-74.03%) ⬇️
superset-frontend/src/explore/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupColors.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/chart/ChartContainer.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/reducers/index.js 0.00% <0.00%> (-100.00%) ⬇️
...et-frontend/src/dashboard/containers/Dashboard.jsx 0.00% <0.00%> (-100.00%) ⬇️
...t-frontend/src/dashboard/containers/SliceAdder.jsx 0.00% <0.00%> (-100.00%) ⬇️
...t-frontend/src/explore/reducers/getInitialState.js 0.00% <0.00%> (-100.00%) ⬇️
... and 181 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 942e321...881635c. Read the comment docs.

@villebro villebro closed this Dec 22, 2020
@villebro villebro reopened this Dec 22, 2020
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just trying to get the flaky tests to pass now.

@dpgaspar dpgaspar merged commit 4ac00a0 into apache:master Dec 23, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants