Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): update tox testing run to relevant python env #12748

Merged
merged 1 commit into from
Jan 28, 2021

Conversation

amitmiran137
Copy link
Member

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Jan 25, 2021

Codecov Report

Merging #12748 (33d249e) into master (0fed1e0) will increase coverage by 0.82%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12748      +/-   ##
==========================================
+ Coverage   66.89%   67.71%   +0.82%     
==========================================
  Files        1022     1023       +1     
  Lines       49994    51644    +1650     
  Branches     4892     5049     +157     
==========================================
+ Hits        33442    34970    +1528     
- Misses      16427    16553     +126     
+ Partials      125      121       -4     
Flag Coverage Δ
cypress 51.35% <ø> (+0.43%) ⬆️
javascript 61.99% <ø> (+0.65%) ⬆️
python 65.04% <ø> (+0.96%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...et-frontend/src/components/Menu/LanguagePicker.tsx 62.50% <0.00%> (-6.74%) ⬇️
superset/db_engine_specs/presto.py 82.25% <0.00%> (-6.28%) ⬇️
...rontend/src/explore/components/DatasourcePanel.tsx 81.25% <0.00%> (-1.36%) ⬇️
superset/models/core.py 88.58% <0.00%> (-0.28%) ⬇️
superset/commands/utils.py 100.00% <0.00%> (ø)
superset-frontend/src/common/components/index.tsx 100.00% <0.00%> (ø)
...perset-frontend/src/dashboard/containers/Chart.jsx 100.00% <0.00%> (ø)
...et-frontend/src/dashboard/containers/Dashboard.jsx 100.00% <0.00%> (ø)
...-frontend/src/common/components/common.stories.tsx 0.00% <0.00%> (ø)
...src/dashboard/util/activeDashboardNativeFilters.ts 96.42% <0.00%> (ø)
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fed1e0...33d249e. Read the comment docs.

@mistercrunch mistercrunch changed the title update tox testing run to relevant python env chore: update tox testing run to relevant python env Jan 26, 2021
@amitmiran137 amitmiran137 reopened this Jan 26, 2021
@amitmiran137 amitmiran137 reopened this Jan 26, 2021
@amitmiran137 amitmiran137 changed the title chore: update tox testing run to relevant python env chore(docs): update tox testing run to relevant python env Jan 26, 2021
@amitmiran137 amitmiran137 reopened this Jan 26, 2021
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should revisit this at some point and remove implicitly running sqlite in favor of using postgres or mysql in a properly containerized test environment.

@villebro villebro merged commit cae751e into apache:master Jan 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants