fix(alerts/reports): misconfigured useEffect hook breaks form valida… #12779
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tion in prod
SUMMARY
A misconfigured instance of the useEffect hook was causing the form validation to not run in prod builds.
I'm guessing
useEffect
has some performance optimizations to minimize updates in prod. Since this is first run with an empty array, react likely disregards subsequent updates after the component is mounted. Usually an error is thrown when react detects changes in the dependency array length. I think the initial empty array is an exception as that has slightly different semantics.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
TEST PLAN
ALERT_REPORTS
feature flagnpm run build
)ADDITIONAL INFORMATION