Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add deprecations to updating.md #12798

Merged

Conversation

eschutho
Copy link
Member

SUMMARY

Per #12566 this adds two sections to the updating.md file for notating deprecations vs breaking changes

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@eschutho eschutho force-pushed the elizabeth/add-deprecation-updating branch from 8b308aa to 1a94e7d Compare January 27, 2021 19:41
@eschutho
Copy link
Member Author

@garden-of-delete

Copy link
Contributor

@garden-of-delete garden-of-delete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for adding this!

@codecov-io
Copy link

codecov-io commented Jan 27, 2021

Codecov Report

Merging #12798 (1a94e7d) into master (55c8f9b) will decrease coverage by 2.90%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12798      +/-   ##
==========================================
- Coverage   66.68%   63.77%   -2.91%     
==========================================
  Files        1021      488     -533     
  Lines       50008    30129   -19879     
  Branches     4905        0    -4905     
==========================================
- Hits        33346    19215   -14131     
+ Misses      16532    10914    -5618     
+ Partials      130        0     -130     
Flag Coverage Δ
cypress ?
javascript ?
python 63.77% <ø> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/sql_validators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
superset/utils/cache.py 76.34% <0.00%> (-8.77%) ⬇️
superset/databases/commands/create.py 83.67% <0.00%> (-8.17%) ⬇️
superset/databases/commands/update.py 85.71% <0.00%> (-8.17%) ⬇️
superset/db_engine_specs/sqlite.py 90.62% <0.00%> (-6.25%) ⬇️
superset/databases/commands/test_connection.py 84.78% <0.00%> (-4.35%) ⬇️
superset/utils/celery.py 96.42% <0.00%> (-3.58%) ⬇️
superset/models/core.py 85.86% <0.00%> (-2.99%) ⬇️
superset/views/core.py 72.97% <0.00%> (-2.42%) ⬇️
superset/db_engine_specs/mysql.py 89.79% <0.00%> (-2.05%) ⬇️
... and 545 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55c8f9b...1a94e7d. Read the comment docs.

@eschutho eschutho changed the title docs:add deprecations to updating.md docs: add deprecations to updating.md Jan 27, 2021
@eschutho
Copy link
Member Author

🏷 v1.0.1

@betodealmeida betodealmeida merged commit ef72406 into apache:master Jan 28, 2021
@eschutho eschutho deleted the elizabeth/add-deprecation-updating branch January 28, 2021 22:38
villebro pushed a commit that referenced this pull request Jan 29, 2021
@mistercrunch mistercrunch added 🍒 1.0.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M v1.0.1 🍒 1.0.1 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants