Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding feature flags v1 documentation in Release Notes #12813

Merged
merged 1 commit into from
Jan 28, 2021

Conversation

srinify
Copy link
Contributor

@srinify srinify commented Jan 28, 2021

SUMMARY

At the moment, the Apache Superset website is unreliably tapping into browser cache. This means that the documentation on 1.0 feature flags isn't accessible in a reliable way.

As we work on / resolve the ASF website caching issues (and find a longer term documentation habit for feature flags), I'm mirroring the documentation in the Release Notes for 1.0 so we can at least have a reliable way to share this information with the community!

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-io
Copy link

Codecov Report

Merging #12813 (fdbf49d) into master (32f2c45) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12813      +/-   ##
==========================================
- Coverage   67.01%   67.00%   -0.01%     
==========================================
  Files        1022     1022              
  Lines       50102    50102              
  Branches     5191     5142      -49     
==========================================
- Hits        33574    33573       -1     
- Misses      16397    16398       +1     
  Partials      131      131              
Flag Coverage Δ
cypress 50.91% <ø> (-0.01%) ⬇️
javascript 61.73% <ø> (ø)
python 64.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...set-frontend/src/dashboard/util/getDropPosition.js 92.06% <0.00%> (-1.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32f2c45...692c487. Read the comment docs.

@srinify srinify merged commit 47edced into apache:master Jan 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/S 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants