feat: Make initial user configurable in helm chart #12862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12862 +/- ##
==========================================
- Coverage 67.04% 66.98% -0.06%
==========================================
Files 1022 1022
Lines 50186 50186
Branches 5204 5204
==========================================
- Hits 33647 33618 -29
- Misses 16404 16433 +29
Partials 135 135
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
amitmiran137
previously requested changes
Mar 19, 2021
Co-authored-by: Amit Miran <47772523+amitmiran137@users.noreply.github.com>
Co-authored-by: Amit Miran <47772523+amitmiran137@users.noreply.github.com>
craig-rueda
approved these changes
Mar 20, 2021
allanco91
pushed a commit
to allanco91/superset
that referenced
this pull request
May 21, 2021
* Make initial user configurable in helm chart * Update helm/superset/values.yaml Co-authored-by: Amit Miran <47772523+amitmiran137@users.noreply.github.com> * Update helm/superset/values.yaml Co-authored-by: Amit Miran <47772523+amitmiran137@users.noreply.github.com> Co-authored-by: Craig Rueda <craig@craigrueda.com> Co-authored-by: Amit Miran <47772523+amitmiran137@users.noreply.github.com>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR updates the helm chart to allow easy configuration of the initial user via helm properties. At the moment, to not use the default admin/admin user, you have to download and modify the chart or to set a the complete init script. With these changes, username/password and the other user details can be set via normal helm properties.
The default behavior does not change.
ADDITIONAL INFORMATION