Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update helm documentation #12932

Merged
merged 3 commits into from
Mar 21, 2021
Merged

docs: update helm documentation #12932

merged 3 commits into from
Mar 21, 2021

Conversation

anthonycorletti
Copy link
Contributor

SUMMARY

Noticed #11363 and updated documentation to reflect a success full deployment on GKE with helm3.

$ helm version && echo && kubectl version && echo && kubectl get po -A
version.BuildInfo{Version:"v3.5.1", GitCommit:"32c22239423b3b4ba6706d450bd044baffdcf9e6", GitTreeState:"dirty", GoVersion:"go1.15.7"}

Client Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.3", GitCommit:"1e11e4a2108024935ecfcb2912226cedeafd99df", GitTreeState:"clean", BuildDate:"2020-10-14T12:50:19Z", GoVersion:"go1.15.2", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"17+", GitVersion:"v1.17.14-gke.1600", GitCommit:"7c407f5cc8632f9af5a2657f220963aa7f1c46e7", GitTreeState:"clean", BuildDate:"2020-12-07T09:22:27Z", GoVersion:"go1.13.15b4", Compiler:"gc", Platform:"linux/amd64"}

NAMESPACE     NAME                                                        READY   STATUS      RESTARTS   AGE
default       superset-77f5b77848-cchs2                                   1/1     Running     0          32m
default       superset-init-db-8q6xw                                      0/1     Completed   0          32m
default       superset-postgresql-0                                       1/1     Running     0          32m
default       superset-redis-master-0                                     1/1     Running     0          32m
default       superset-worker-86945968b4-56zdf                            1/1     Running     0          32m
kube-system   event-exporter-gke-666b7ffbf7-sv5wg                         2/2     Running     0          93m
kube-system   fluentbit-gke-42qh8                                         2/2     Running     0          93m
kube-system   fluentbit-gke-gq544                                         2/2     Running     0          93m
kube-system   fluentbit-gke-zjtd7                                         2/2     Running     0          93m
kube-system   gke-metrics-agent-2qs5z                                     1/1     Running     0          93m
kube-system   gke-metrics-agent-6n7bm                                     1/1     Running     0          93m
kube-system   gke-metrics-agent-fjfvk                                     1/1     Running     0          93m
kube-system   kube-dns-9c59558bb-wvmkf                                    4/4     Running     0          93m
kube-system   kube-dns-9c59558bb-xrqnk                                    4/4     Running     0          93m
kube-system   kube-dns-autoscaler-5c78d65cd9-q4ng2                        1/1     Running     0          93m
kube-system   kube-proxy-gke-superset-test-default-pool-900766ff-1cwt     1/1     Running     0          93m
kube-system   kube-proxy-gke-superset-test-default-pool-900766ff-k1nt     1/1     Running     0          93m
kube-system   kube-proxy-gke-superset-test-default-pool-900766ff-vvj4     1/1     Running     0          93m
kube-system   l7-default-backend-5b76b455d-db4kl                          1/1     Running     0          93m
kube-system   metrics-server-v0.3.6-547dc87f5f-44kbj                      2/2     Running     0          92m
kube-system   prometheus-to-sd-7rrkt                                      1/1     Running     0          93m
kube-system   prometheus-to-sd-fxvxk                                      1/1     Running     0          93m
kube-system   prometheus-to-sd-thc28                                      1/1     Running     0          93m
kube-system   stackdriver-metadata-agent-cluster-level-56d688675d-lsdqr   2/2     Running     0          92m

ADDITIONAL INFORMATION

Can publish these on merge wrt https://github.com/apache/superset/blob/master/docs/README.md#to-publish

@codecov-io
Copy link

codecov-io commented Feb 3, 2021

Codecov Report

Merging #12932 (89f7398) into master (daefebb) will decrease coverage by 8.44%.
The diff coverage is n/a.

❗ Current head 89f7398 differs from pull request most recent head 74f4c93. Consider uploading reports for the commit 74f4c93 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12932      +/-   ##
==========================================
- Coverage   77.39%   68.94%   -8.45%     
==========================================
  Files         928     1025      +97     
  Lines       47024    48765    +1741     
  Branches     5812     5241     -571     
==========================================
- Hits        36393    33623    -2770     
- Misses      10488    15008    +4520     
+ Partials      143      134       -9     
Flag Coverage Δ
cypress 50.83% <ø> (-5.61%) ⬇️
hive ?
javascript 61.83% <ø> (-1.31%) ⬇️
mysql ?
postgres ?
presto ?
python 67.29% <ø> (-13.83%) ⬇️
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/components/ErrorMessage/IssueCode.tsx 0.00% <0.00%> (-100.00%) ⬇️
...rc/components/ErrorMessage/TimeoutErrorMessage.tsx 0.00% <0.00%> (-100.00%) ⬇️
...c/components/ErrorMessage/DatabaseErrorMessage.tsx 0.00% <0.00%> (-94.74%) ⬇️
.../components/ErrorMessage/ParameterErrorMessage.tsx 6.25% <0.00%> (-90.63%) ⬇️
...ponents/Select/WindowedSelect/WindowedMenuList.tsx 10.71% <0.00%> (-85.72%) ⬇️
superset-frontend/src/utils/copy.ts 11.53% <0.00%> (-84.62%) ⬇️
...nd/src/filters/components/Select/transformProps.ts 0.00% <0.00%> (-81.82%) ⬇️
...ontend/src/filters/components/Select/buildQuery.ts 0.00% <0.00%> (-77.78%) ⬇️
...rontend/src/components/ErrorMessage/ErrorAlert.tsx 20.40% <0.00%> (-73.47%) ⬇️
...nd/src/components/ErrorMessage/BasicErrorAlert.tsx 35.29% <0.00%> (-64.71%) ⬇️
... and 739 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daefebb...74f4c93. Read the comment docs.

@anthonycorletti
Copy link
Contributor Author

noting that requirements.yaml is deprecated in helm 3 https://helm.sh/docs/faq/#consolidation-of-requirementsyaml-into-chartyaml

@amitmiran137
Copy link
Member

Look like a re doing of #11763

Copy link
Member

@craig-rueda craig-rueda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left inline comment. Please also remove requiments.yaml / requirements.locl in favor of keeping everything in Chart.yaml.

helm/superset/Chart.yaml Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/M and removed size/S labels Mar 21, 2021
@craig-rueda craig-rueda merged commit 6c3bfe8 into apache:master Mar 21, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
* docs: update helm documentation

* docs: fix for end-of-file-fixer pre-commit-config

* update: bump chart apiVersion to v2 and remove requirements.yaml
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants