Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(native-filters): hide filterBar and toggle icon when in editMode #13108

Merged
merged 2 commits into from
Feb 14, 2021

Conversation

amitmiran137
Copy link
Member

@amitmiran137 amitmiran137 commented Feb 13, 2021

SUMMARY

sometimes I can do frontend.
resolves #12629

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

hide_filter_bar.mov

TEST PLAN

  1. enable DASHBOARD_NATIVE_FILTERS FF
  2. go to a dashboard
  3. toggle the filter bar
  4. click edit dashboard icon
  5. check filter bar disappears and toggle icon also

ADDITIONAL INFORMATION

@amitmiran137 amitmiran137 added the dashboard:native-filters Related to the native filters of the Dashboard label Feb 13, 2021
@codecov-io
Copy link

codecov-io commented Feb 13, 2021

Codecov Report

Merging #13108 (6de74e0) into master (2ce7982) will increase coverage by 8.63%.
The diff coverage is 34.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13108      +/-   ##
==========================================
+ Coverage   53.06%   61.69%   +8.63%     
==========================================
  Files         489      553      +64     
  Lines       17314    20253    +2939     
  Branches     4482     5301     +819     
==========================================
+ Hits         9187    12495    +3308     
+ Misses       8127     7544     -583     
- Partials        0      214     +214     
Flag Coverage Δ
cypress ?
javascript 61.69% <34.81%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...end/src/SqlLab/components/RunQueryActionButton.tsx 64.28% <ø> (+11.50%) ⬆️
superset-frontend/src/chart/ChartContainer.jsx 100.00% <ø> (ø)
superset-frontend/src/chart/ChartRenderer.jsx 39.18% <0.00%> (-37.53%) ⬇️
...perset-frontend/src/common/components/Dropdown.tsx 54.76% <ø> (+4.76%) ⬆️
...ontend/src/components/ListViewCard/ImageLoader.tsx 86.36% <0.00%> (+11.36%) ⬆️
...set-frontend/src/components/URLShortLinkButton.jsx 100.00% <ø> (ø)
...src/dashboard/components/HeaderActionsDropdown.jsx 54.79% <ø> (-12.78%) ⬇️
...end/src/dashboard/components/StickyVerticalBar.tsx 50.00% <ø> (-50.00%) ⬇️
...ponents/nativeFilters/FilterBar/CascadePopover.tsx 20.28% <0.00%> (-76.38%) ⬇️
...d/components/nativeFilters/FilterBar/FilterBar.tsx 70.93% <0.00%> (-24.46%) ⬇️
... and 517 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc4c837...6de74e0. Read the comment docs.

@amitmiran137 amitmiran137 merged commit d55a040 into master Feb 14, 2021
@amitmiran137 amitmiran137 deleted the feat/disable_filter_bar_in_edit_mode branch March 29, 2021 08:24
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dashboard:native-filters Related to the native filters of the Dashboard size/XS 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dashboard]native filter collapse icon should hide in edit mode
5 participants