feat(explore): adhoc column formatting for Table chart #13758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktmud
force-pushed
the
table-column-formatting
branch
from
2c1a471
to
7019a5f
Compare
ktmud
force-pushed
the
table-column-formatting
branch
2 times, most recently
from
a55f820
to
890b6cd
Compare
etr2460
reviewed
Mar 29, 2021
| ...config, | ||
| ...controls[name], | ||
| name, | ||
| }; | ||
| if (config.mapStateToProps?.length === 3) { |
There was a problem hiding this comment.
what does this mean? maybe a comment to show why it's necessary?
etr2460
reviewed
Mar 29, 2021
superset-frontend/src/explore/components/ControlPanelsContainer.tsx
Outdated
Show resolved
Hide resolved
ktmud
force-pushed
the
table-column-formatting
branch
2 times, most recently
from
145bea3
to
3c93b75
Compare
etr2460
approved these changes
Mar 30, 2021
ktmud
force-pushed
the
table-column-formatting
branch
from
3c93b75
to
d95514d
Compare
|
It seems emotion's |
Codecov Report
@@ Coverage Diff @@
## master #13758 +/- ##
=======================================
Coverage 78.09% 78.09%
=======================================
Files 934 934
Lines 47345 47350 +5
Branches 5937 5945 +8
=======================================
+ Hits 36972 36976 +4
- Misses 10229 10230 +1
Partials 144 144
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ktmud
force-pushed
the
table-column-formatting
branch
2 times, most recently
from
95b2c8d
to
421335e
Compare
ktmud
force-pushed
the
table-column-formatting
branch
from
421335e
to
73166b5
Compare
|
/testenv up |
|
@ktmud Ephemeral environment creation is currently limited to committers. |
amitmiran137
pushed a commit
that referenced
this pull request
Apr 2, 2021
* master: (26 commits) chore: bump to new superset-ui version (#13932) fix: do not run containers as root by default in Helm chart (#13917) feat(explore): adhoc column formatting for Table chart (#13758) fix(sqla-query): order by aggregations in Presto and Hive (#13739) feat(alert/report): add ALERTS_ATTACH_REPORTS feature flags + feature (#13894) test: Fixes PropertiesModal_spec (#13548) fix: Pin Prophet dependency after breaking changes (#13852) test: Adds tests to dnd controls (#13650) test: Adds tests to the AnnotationLayer component (#13748) test: Refactor and enhance tests for the Explore DatasourcePanel Component (#13799) Add tests (#13778) test: DisplayQueryButton (#13750) Fixing condition around left margin for dashboard layout. Fixes #13863 (#13905) Revert "fix: select table overlay (#13694)" (#13901) test: Adds tests to the OptionControls component (#13729) test: DatasourceControl (#13605) tests for function handleScroll (#13896) test: Adds tests to the CustomFrame component (#13675) test: Adds tests to the AdvancedFrame component (#13664) test: DataTableControl (#13668) ...
allanco91
pushed a commit
to allanco91/superset
that referenced
this pull request
May 21, 2021
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add ad-hoc per-column formatting to table chart so users can change things like column width and d3 format after querying.
Most logics are built in
superset-ui, with this PR: apache-superset/superset-ui#1019The only change in
superset-frontendis to pass chart state to controls.Closes #10729 .
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
See apache-superset/superset-ui#1019 for more screenshots.
TEST PLAN
Manual testing
ADDITIONAL INFORMATION