Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(native-filters): add tooltip to control values #14312

Merged
merged 1 commit into from
Apr 23, 2021

Conversation

villebro
Copy link
Member

SUMMARY

Add tooltip to native filter controls (see screenshot).

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #14312 (7ce4641) into master (b963624) will increase coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head 7ce4641 differs from pull request most recent head bd4929a. Consider uploading reports for the commit bd4929a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14312      +/-   ##
==========================================
+ Coverage   76.93%   77.02%   +0.08%     
==========================================
  Files         954      954              
  Lines       48075    48078       +3     
  Branches     5974     5977       +3     
==========================================
+ Hits        36987    37031      +44     
+ Misses      10891    10850      -41     
  Partials      197      197              
Flag Coverage Δ
javascript 72.10% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nts/controls/DateFilterControl/DateFilterLabel.tsx 73.72% <ø> (-0.23%) ⬇️
...trols/DateFilterControl/components/CustomFrame.tsx 92.15% <ø> (ø)
...ontrols/DateFilterControl/utils/dateFilterUtils.ts 100.00% <ø> (ø)
...tend/src/filters/components/Select/controlPanel.ts 63.63% <ø> (ø)
...tersConfigModal/FiltersConfigForm/ControlItems.tsx 100.00% <100.00%> (ø)
...ols/DateFilterControl/components/AdvancedFrame.tsx 100.00% <100.00%> (ø)
...nts/controls/DateFilterControl/utils/dateParser.ts 96.15% <100.00%> (ø)
...mponents/controls/DateFilterControl/utils/index.ts 100.00% <100.00%> (ø)
superset/models/core.py 89.13% <0.00%> (+0.27%) ⬆️
superset/connectors/sqla/models.py 90.07% <0.00%> (+1.45%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b963624...bd4929a. Read the comment docs.

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@junlincc junlincc added the dashboard:native-filters Related to the native filters of the Dashboard label Apr 23, 2021
@villebro villebro merged commit 2b57eba into apache:master Apr 23, 2021
@villebro villebro deleted the villebro/native-tooltip branch April 23, 2021 16:29
amitmiran137 pushed a commit that referenced this pull request Apr 27, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dashboard:native-filters Related to the native filters of the Dashboard preset-io size/S v1.2 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants